Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1980473002: Move collapseAnonymousBlockChild() to LayoutBlockFlow, and make it non-static. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
szager1, wkorman, eae
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, Manuel Rego, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move collapseAnonymousBlockChild() to LayoutBlockFlow, and make it non-static. Some cleanup in collapseLoneAnonymousBlockChild(). Specify a parent rather than working it out on our own. Both callers have the parent readily available anyway. Remove canCollapseAnonymousBlockChild(), since nobody calls it anymore. BUG=302024 Committed: https://crrev.com/a4d03b3c5f8b03ecc44acd3e52c4a6e430806d4c Cr-Commit-Position: refs/heads/master@{#393542}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -45 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 6 chunks +26 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 2 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutButton.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-13 13:16:32 UTC) #2
eae
LGTM
4 years, 7 months ago (2016-05-13 16:25:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980473002/1
4 years, 7 months ago (2016-05-13 16:25:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 16:29:29 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 16:30:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4d03b3c5f8b03ecc44acd3e52c4a6e430806d4c
Cr-Commit-Position: refs/heads/master@{#393542}

Powered by Google App Engine
This is Rietveld 408576698