Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 1980473002: Move collapseAnonymousBlockChild() to LayoutBlockFlow, and make it non-static. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
index 7be475bd7ae129ad8e1d459570defd90960c1736..464aa2775f1b570c3ff8dbf14ec791a4f63b1d77 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -4567,15 +4567,13 @@ static void markBoxForRelayoutAfterSplit(LayoutBox* box)
box->setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidation(LayoutInvalidationReason::AnonymousBlockChange);
}
-static void collapseLoneAnonymousBlockChild(LayoutObject* child)
+static void collapseLoneAnonymousBlockChild(LayoutBox* parent, LayoutObject* child)
{
- ASSERT(child);
- if (!child->isAnonymousBlock())
+ if (!child->isAnonymousBlock() || !child->isLayoutBlockFlow())
return;
- LayoutObject* parent = child->parent();
- if (!parent->isLayoutBlock())
+ if (!parent->isLayoutBlockFlow())
return;
- LayoutBlock::collapseAnonymousBlockChild(toLayoutBlock(parent), toLayoutBlock(child));
+ toLayoutBlockFlow(parent)->collapseAnonymousBlockChild(toLayoutBlockFlow(child));
}
LayoutObject* LayoutBox::splitAnonymousBoxesAroundChild(LayoutObject* beforeChild)
@@ -4601,11 +4599,11 @@ LayoutObject* LayoutBox::splitAnonymousBoxesAroundChild(LayoutObject* beforeChil
LayoutObject* child = postBox->slowFirstChild();
ASSERT(child);
if (child && !child->nextSibling())
- collapseLoneAnonymousBlockChild(child);
+ collapseLoneAnonymousBlockChild(postBox, child);
child = boxToSplit->slowFirstChild();
ASSERT(child);
if (child && !child->nextSibling())
- collapseLoneAnonymousBlockChild(child);
+ collapseLoneAnonymousBlockChild(boxToSplit, child);
markBoxForRelayoutAfterSplit(boxToSplit);
markBoxForRelayoutAfterSplit(postBox);
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutButton.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698