[Interpreter] Inline Inc/Dec code stubs into bytecode handlers.

[Interpreter] Inline Inc/Dec code stubs into bytecode handlers.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/776d4d87a98b4bd402cae80f78186fc5b8ab91bd
Cr-Commit-Position: refs/heads/master@{#36314}

[rmcilroy, 2016-05-13 21:41:18]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-13 21:41:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1980463003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1980463003/1

[commit-bot: I haz the power, 2016-05-13 21:42:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 21:42:37]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/5763)
  v8_linux_arm64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/5752)
  v8_mac_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/1654)

[rmcilroy, 2016-05-16 15:31:18]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-16 15:31:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1980463003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1980463003/20001

[rmcilroy, 2016-05-16 15:32:55]

rmcilroy@chromium.org changed reviewers:
+ epertoso@chromium.org

[rmcilroy, 2016-05-16 15:32:56]

Enrico, this does the same for Inc/Dec as you've done for binary stubs. I'll
wait to land this until you reland binary op stubs inlining. PTAL, thanks.

[commit-bot: I haz the power, 2016-05-16 16:20:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-16 16:20:54]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[rmcilroy, 2016-05-17 14:04:04]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 14:04:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1980463003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1980463003/40001

[commit-bot: I haz the power, 2016-05-17 14:05:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 14:05:25]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/5833)
  v8_linux_arm64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/5847)
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/5823)
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/15346)

[rmcilroy, 2016-05-17 14:31:39]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 14:31:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1980463003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1980463003/60001

[commit-bot: I haz the power, 2016-05-17 15:02:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 15:02:10]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-05-17 15:15:10]

Fixed the previous typo, PTAL, thanks.

[epertoso, 2016-05-17 15:21:52]

lgtm

LGTM with a couple of nits.

https://codereview.chromium.org/1980463003/diff/60001/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/1980463003/diff/60001/src/code-stubs.h#newcod...
src/code-stubs.h:417: #define DEFINE_TURBOFAN_COUNT_OP_CODE_STUB(NAME, SUPER)   
            \
nit: UNARY_OP instead of COUNT_OP.

https://codereview.chromium.org/1980463003/diff/60001/src/interpreter/interpr...
File src/interpreter/interpreter.h (right):

https://codereview.chromium.org/1980463003/diff/60001/src/interpreter/interpr...
src/interpreter/interpreter.h:82: void DoCountOp(InterpreterAssembler*
assembler);
Same here, how about renaming this one to DoUnaryOp?

[rmcilroy, 2016-05-17 19:59:17]

https://codereview.chromium.org/1980463003/diff/60001/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/1980463003/diff/60001/src/code-stubs.h#newcod...
src/code-stubs.h:417: #define DEFINE_TURBOFAN_COUNT_OP_CODE_STUB(NAME, SUPER)   
            \
On 2016/05/17 15:21:52, epertoso wrote:
> nit: UNARY_OP instead of COUNT_OP.

Done.

https://codereview.chromium.org/1980463003/diff/60001/src/interpreter/interpr...
File src/interpreter/interpreter.h (right):

https://codereview.chromium.org/1980463003/diff/60001/src/interpreter/interpr...
src/interpreter/interpreter.h:82: void DoCountOp(InterpreterAssembler*
assembler);
On 2016/05/17 15:21:52, epertoso wrote:
> Same here, how about renaming this one to DoUnaryOp?

Done.

[rmcilroy, 2016-05-18 09:12:49]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2016-05-18 09:12:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
epertoso@chromium.org
Link to the patchset: https://codereview.chromium.org/1980463003/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2016-05-18 09:13:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1980463003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1980463003/100001

[commit-bot: I haz the power, 2016-05-18 09:43:47]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-05-18 09:45:25]

Description was changed from

==========
[Interpreter] Inline Inc/Dec code stubs into bytecode handlers.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Inline Inc/Dec code stubs into bytecode handlers.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/776d4d87a98b4bd402cae80f78186fc5b8ab91bd
Cr-Commit-Position: refs/heads/master@{#36314}
==========

[commit-bot: I haz the power, 2016-05-18 09:45:26]

Patchset 6 (id:??) landed as
https://crrev.com/776d4d87a98b4bd402cae80f78186fc5b8ab91bd
Cr-Commit-Position: refs/heads/master@{#36314}