 Chromium Code Reviews
 Chromium Code Reviews Issue 1980463003:
  [Interpreter] Inline Inc/Dec code stubs into bytecode handlers.  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master
    
  
    Issue 1980463003:
  [Interpreter] Inline Inc/Dec code stubs into bytecode handlers.  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master| OLD | NEW | 
|---|---|
| 1 // Copyright 2015 the V8 project authors. All rights reserved. | 1 // Copyright 2015 the V8 project authors. All rights reserved. | 
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be | 
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. | 
| 4 | 4 | 
| 5 #ifndef V8_INTERPRETER_INTERPRETER_H_ | 5 #ifndef V8_INTERPRETER_INTERPRETER_H_ | 
| 6 #define V8_INTERPRETER_INTERPRETER_H_ | 6 #define V8_INTERPRETER_INTERPRETER_H_ | 
| 7 | 7 | 
| 8 // Clients of this interface shouldn't depend on lots of interpreter internals. | 8 // Clients of this interface shouldn't depend on lots of interpreter internals. | 
| 9 // Do not include anything from src/interpreter other than | 9 // Do not include anything from src/interpreter other than | 
| 10 // src/interpreter/bytecodes.h here! | 10 // src/interpreter/bytecodes.h here! | 
| (...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 70 void DoBinaryOp(Callable callable, InterpreterAssembler* assembler); | 70 void DoBinaryOp(Callable callable, InterpreterAssembler* assembler); | 
| 71 | 71 | 
| 72 // Generates code to perform the binary operations via |function_id|. | 72 // Generates code to perform the binary operations via |function_id|. | 
| 73 void DoBinaryOp(Runtime::FunctionId function_id, | 73 void DoBinaryOp(Runtime::FunctionId function_id, | 
| 74 InterpreterAssembler* assembler); | 74 InterpreterAssembler* assembler); | 
| 75 | 75 | 
| 76 // Generates code to perform the binary operations via |Generator|. | 76 // Generates code to perform the binary operations via |Generator|. | 
| 77 template <class Generator> | 77 template <class Generator> | 
| 78 void DoBinaryOp(InterpreterAssembler* assembler); | 78 void DoBinaryOp(InterpreterAssembler* assembler); | 
| 79 | 79 | 
| 80 // Generates code to perform the count operations via |callable|. | 80 // Generates code to perform the count operations via |Generator|. | 
| 81 void DoCountOp(Callable callable, InterpreterAssembler* assembler); | 81 template <class Generator> | 
| 82 void DoCountOp(InterpreterAssembler* assembler); | |
| 
epertoso
2016/05/17 15:21:52
Same here, how about renaming this one to DoUnaryO
 
rmcilroy
2016/05/17 19:59:17
Done.
 | |
| 82 | 83 | 
| 83 // Generates code to perform the comparison operation associated with | 84 // Generates code to perform the comparison operation associated with | 
| 84 // |compare_op|. | 85 // |compare_op|. | 
| 85 void DoCompareOp(Token::Value compare_op, InterpreterAssembler* assembler); | 86 void DoCompareOp(Token::Value compare_op, InterpreterAssembler* assembler); | 
| 86 | 87 | 
| 87 // Generates code to load a constant from the constant pool. | 88 // Generates code to load a constant from the constant pool. | 
| 88 void DoLoadConstant(InterpreterAssembler* assembler); | 89 void DoLoadConstant(InterpreterAssembler* assembler); | 
| 89 | 90 | 
| 90 // Generates code to perform a global load via |ic|. | 91 // Generates code to perform a global load via |ic|. | 
| 91 void DoLoadGlobal(Callable ic, InterpreterAssembler* assembler); | 92 void DoLoadGlobal(Callable ic, InterpreterAssembler* assembler); | 
| (...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 152 v8::base::SmartArrayPointer<uintptr_t> bytecode_dispatch_counters_table_; | 153 v8::base::SmartArrayPointer<uintptr_t> bytecode_dispatch_counters_table_; | 
| 153 | 154 | 
| 154 DISALLOW_COPY_AND_ASSIGN(Interpreter); | 155 DISALLOW_COPY_AND_ASSIGN(Interpreter); | 
| 155 }; | 156 }; | 
| 156 | 157 | 
| 157 } // namespace interpreter | 158 } // namespace interpreter | 
| 158 } // namespace internal | 159 } // namespace internal | 
| 159 } // namespace v8 | 160 } // namespace v8 | 
| 160 | 161 | 
| 161 #endif // V8_INTERPRETER_INTERPRETER_H_ | 162 #endif // V8_INTERPRETER_INTERPRETER_H_ | 
| OLD | NEW |