Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: src/snapshot/snapshot-common.cc

Issue 1980333002: [ignition] Inline the binary op TurboFan code stubs in the bytecode handlers. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/interpreter.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/snapshot/snapshot-common.cc
diff --git a/src/snapshot/snapshot-common.cc b/src/snapshot/snapshot-common.cc
index eb3bdb56045af089b0693dc13fe8fee797393296..d7d983ecad06b72e67d0defd9b254dae9f9df78d 100644
--- a/src/snapshot/snapshot-common.cc
+++ b/src/snapshot/snapshot-common.cc
@@ -143,8 +143,10 @@ void CalculateFirstPageSizes(bool is_default_snapshot,
// Add a small allowance to the code space for small scripts.
if (space == CODE_SPACE) required += 32 * KB;
} else {
- // We expect the vanilla snapshot to only require on page per space.
- DCHECK(!is_default_snapshot);
+ if (!FLAG_debug_code) {
Yang 2016/05/17 11:12:57 I don't feel too strongly about this, but we could
epertoso 2016/05/17 12:21:20 Done.
+ // We expect the vanilla snapshot to only require on page per space.
rmcilroy 2016/05/17 10:45:23 /s/on/one /s/per space./per space, unless we are e
epertoso 2016/05/17 11:02:31 Done.
+ DCHECK(!is_default_snapshot);
+ }
}
if (space >= FIRST_PAGED_SPACE && space <= LAST_PAGED_SPACE) {
« no previous file with comments | « src/interpreter/interpreter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698