[ignition] Inline the binary op TurboFan code stubs in the bytecode handlers.

src/snapshot/snapshot-common.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The common functionality when building with or without snapshots.
 
 #include "src/snapshot/snapshot.h"
 
 #include "src/api.h"
 #include "src/base/platform/platform.h"
@@ skipping 125 matching lines @@
       // If both the startup snapshot data and the context snapshot data on
       // this space fit in a single page, then we consider limiting the size
       // of the first page. For this, we add the chunk sizes and some extra
       // allowance. This way we achieve a smaller startup memory footprint.
       required = (startup_reservations[startup_index].chunk_size() +
                   2 * context_reservations[context_index].chunk_size()) +
                  Page::kObjectStartOffset;
       // Add a small allowance to the code space for small scripts.
       if (space == CODE_SPACE) required += 32 * KB;
     } else {
-      // We expect the vanilla snapshot to only require on page per space.
-      DCHECK(!is_default_snapshot);
+      if (!FLAG_debug_code) {

[Yang, 2016/05/17 11:12:57]

I don't feel too strongly about this, but we could make this an "else if" :)

[epertoso, 2016/05/17 12:21:20]

Done.

+        // We expect the vanilla snapshot to only require on page per space.

[rmcilroy, 2016/05/17 10:45:23]

/s/on/one
/s/per space./per space, unless we are emitting debug code./

[epertoso, 2016/05/17 11:02:31]

Done.

+        DCHECK(!is_default_snapshot);
+      }
     }
 
     if (space >= FIRST_PAGED_SPACE && space <= LAST_PAGED_SPACE) {
       uint32_t max_size =
           MemoryAllocator::PageAreaSize(static_cast<AllocationSpace>(space));
       sizes_out[space - FIRST_PAGED_SPACE] = Min(required, max_size);
     } else {
       DCHECK(single_chunk);
     }
     startup_index++;
@@ skipping 115 matching lines @@
 Vector<const byte> SnapshotData::Payload() const {
   int reservations_size = GetHeaderValue(kNumReservationsOffset) * kInt32Size;
   const byte* payload = data_ + kHeaderSize + reservations_size;
   int length = GetHeaderValue(kPayloadLengthOffset);
   DCHECK_EQ(data_ + size_, payload + length);
   return Vector<const byte>(payload, length);
 }
 
 }  // namespace internal
 }  // namespace v8