[ignition] Inline the binary op TurboFan code stubs in the bytecode handlers.

[ignition] Inline the binary op TurboFan code stubs in the bytecode handlers.

Trying to reland http://crrev.com/1974293002.

This time some blocks have been shuffled around in the AddStub so that the frame still doesn't get built for the fast path.

Also disables the DCHECK(!is_default_snapshot) in snapshot-common.cc if --debug-code is specified. This was causing cctest to fail on arm64 debug builds.

Committed: https://crrev.com/f43ed04f50bb9c064e475552c9cc08fad72e0176
Cr-Commit-Position: refs/heads/master@{#36279}

[epertoso, 2016-05-17 08:48:00]

Description was changed from

==========
[ignition] Inline the binary op TurboFan code stubs in the bytecode handlers.

Trying to reland http://crrev.com/1902823002.

This time some blocks have been shuffled around in the AddStub so that the frame
still doesn't get built for the fast path.

Also disables the DCHECK(!is_default_snapshot) in snapshot-common.cc if
--debug-code is specified.
==========

to

==========
[ignition] Inline the binary op TurboFan code stubs in the bytecode handlers.

Trying to reland http://crrev.com/1974293002.

This time some blocks have been shuffled around in the AddStub so that the frame
still doesn't get built for the fast path.

Also disables the DCHECK(!is_default_snapshot) in snapshot-common.cc if
--debug-code is specified. This was causing cctest to fail on arm64 debug
builds.
==========

[epertoso, 2016-05-17 08:48:12]

epertoso@chromium.org changed reviewers:
+ bmeurer@chromium.org

[epertoso, 2016-05-17 08:48:15]

The CQ bit was checked by epertoso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 08:48:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1980333002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1980333002/1

[commit-bot: I haz the power, 2016-05-17 09:21:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 09:21:02]

Dry run: This issue passed the CQ dry run.

[epertoso, 2016-05-17 09:43:10]

epertoso@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[epertoso, 2016-05-17 09:43:10]

epertoso@chromium.org changed required reviewers:
+ rmcilroy@chromium.org

[rmcilroy, 2016-05-17 10:45:23]

LGTM, thanks.

https://codereview.chromium.org/1980333002/diff/1/src/snapshot/snapshot-commo...
File src/snapshot/snapshot-common.cc (right):

https://codereview.chromium.org/1980333002/diff/1/src/snapshot/snapshot-commo...
src/snapshot/snapshot-common.cc:147: // We expect the vanilla snapshot to only
require on page per space.
/s/on/one
/s/per space./per space, unless we are emitting debug code./

[epertoso, 2016-05-17 11:02:23]

Patchset #2 (id:20001) has been deleted

[epertoso, 2016-05-17 11:02:31]

https://codereview.chromium.org/1980333002/diff/1/src/snapshot/snapshot-commo...
File src/snapshot/snapshot-common.cc (right):

https://codereview.chromium.org/1980333002/diff/1/src/snapshot/snapshot-commo...
src/snapshot/snapshot-common.cc:147: // We expect the vanilla snapshot to only
require on page per space.
On 2016/05/17 at 10:45:23, rmcilroy wrote:
> /s/on/one
> /s/per space./per space, unless we are emitting debug code./

Done.

[epertoso, 2016-05-17 11:02:34]

The CQ bit was checked by epertoso@chromium.org

[epertoso, 2016-05-17 11:02:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1980333002/#ps40001
(title: "Update")

[commit-bot: I haz the power, 2016-05-17 11:02:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1980333002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1980333002/40001

[commit-bot: I haz the power, 2016-05-17 11:05:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 11:05:29]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/15322)

[Yang, 2016-05-17 11:12:56]

yangguo@chromium.org changed reviewers:
+ yangguo@chromium.org

[Yang, 2016-05-17 11:12:57]

src/snapshot lgtm.

https://codereview.chromium.org/1980333002/diff/1/src/snapshot/snapshot-commo...
File src/snapshot/snapshot-common.cc (right):

https://codereview.chromium.org/1980333002/diff/1/src/snapshot/snapshot-commo...
src/snapshot/snapshot-common.cc:146: if (!FLAG_debug_code) {
I don't feel too strongly about this, but we could make this an "else if" :)

[epertoso, 2016-05-17 12:21:20]

https://codereview.chromium.org/1980333002/diff/1/src/snapshot/snapshot-commo...
File src/snapshot/snapshot-common.cc (right):

https://codereview.chromium.org/1980333002/diff/1/src/snapshot/snapshot-commo...
src/snapshot/snapshot-common.cc:146: if (!FLAG_debug_code) {
On 2016/05/17 at 11:12:57, Yang wrote:
> I don't feel too strongly about this, but we could make this an "else if" :)

Done.

[epertoso, 2016-05-17 12:23:21]

The CQ bit was checked by epertoso@chromium.org

[epertoso, 2016-05-17 12:23:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org, yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1980333002/#ps60001
(title: "Update")

[commit-bot: I haz the power, 2016-05-17 12:23:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1980333002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1980333002/60001

[commit-bot: I haz the power, 2016-05-17 13:14:10]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-05-17 13:14:55]

Description was changed from

==========
[ignition] Inline the binary op TurboFan code stubs in the bytecode handlers.

Trying to reland http://crrev.com/1974293002.

This time some blocks have been shuffled around in the AddStub so that the frame
still doesn't get built for the fast path.

Also disables the DCHECK(!is_default_snapshot) in snapshot-common.cc if
--debug-code is specified. This was causing cctest to fail on arm64 debug
builds.
==========

to

==========
[ignition] Inline the binary op TurboFan code stubs in the bytecode handlers.

Trying to reland http://crrev.com/1974293002.

This time some blocks have been shuffled around in the AddStub so that the frame
still doesn't get built for the fast path.

Also disables the DCHECK(!is_default_snapshot) in snapshot-common.cc if
--debug-code is specified. This was causing cctest to fail on arm64 debug
builds.

Committed: https://crrev.com/f43ed04f50bb9c064e475552c9cc08fad72e0176
Cr-Commit-Position: refs/heads/master@{#36279}
==========

[commit-bot: I haz the power, 2016-05-17 13:14:56]

Patchset 3 (id:??) landed as
https://crrev.com/f43ed04f50bb9c064e475552c9cc08fad72e0176
Cr-Commit-Position: refs/heads/master@{#36279}