Issue 19803007: Update disassembler in NaCl binutils

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19803007: Update disassembler in NaCl binutils (Closed)

Created:
7 years, 5 months ago by khim

Modified:
7 years, 5 months ago

Reviewers:
Vlad Shcherbina, shcherbina - please use other

CC:
native-client-reviews_googlegroups.com

Base URL:
http://git.chromium.org/native_client/nacl-binutils.git@master

Visibility:
Public.

More Reviews

Description

Update disassembler in NaCl binutils We need newer version of disassembler for the validator tests (with support for newer instructions like tzcnt) and till now we've used complex dance which pulls new version of binutils and builds it when needed. It's slow and error-prone. Backport i386-dis.c from trunk instead (specifically from commit from 27 Mar 2013, eb87183adc1fb9e7763a192d0d4577547f250ec9) BUG=http://code.google.com/p/nativeclient/issues/detail?id=3453 TEST=trybots R=shcherbina@chromium.org Committed: https://git.chromium.org/gitweb?p=native_client/nacl-binutils.git;a=commit;h=8060546

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7462 lines, -5100 lines)			Patch
	M	opcodes/i386-dis.c	View		177 chunks	+7462 lines, -5100 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vlad Shcherbina

LGTM. Note: bumping revisions and deps will break validator targeted tests. I'm going to bump ...

7 years, 5 months ago (2013-07-23 14:26:47 UTC) #2

khim

7 years, 5 months ago (2013-07-23 14:31:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r8060546 (presubmit successful).

Expand Messages | Collapse Messages