Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 1980223002: Revert of Replace Release() { delete this; } in fde_xml_imp.h (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert of Replace Release() { delete this; } in fde_xml_imp.h (patchset #7 id:120001 of https://codereview.chromium.org/1981003002/ ) Reason for revert: Broke the ASAN Bot Original issue's description: > Replace Release() { delete this; } in fde_xml_imp.h > > Committed: https://pdfium.googlesource.com/pdfium/+/fa34e805fd03ba81bcfe1148cf96b24fe63b39a0 TBR=tsepez@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -151 lines) Patch
M testing/libfuzzer/pdf_xml_fuzzer.cc View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fde/xml/fde_xml_imp.h View 10 chunks +50 lines, -51 lines 0 comments Download
M xfa/fde/xml/fde_xml_imp.cpp View 6 chunks +27 lines, -37 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdoc.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M xfa/fxfa/parser/xfa_document.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document_imp.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_serialize.cpp View 3 chunks +20 lines, -17 lines 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 3 chunks +21 lines, -13 lines 0 comments Download
M xfa/fxfa/parser/xfa_parser.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_parser_imp.h View 4 chunks +10 lines, -8 lines 0 comments Download
M xfa/fxfa/parser/xfa_parser_imp.cpp View 3 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Lei Zhang
Created Revert of Replace Release() { delete this; } in fde_xml_imp.h
4 years, 7 months ago (2016-05-16 22:57:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980223002/1
4 years, 7 months ago (2016-05-16 22:57:22 UTC) #2
commit-bot: I haz the power
Failed to apply the patch.
4 years, 7 months ago (2016-05-16 22:57:31 UTC) #4
Tom Sepez
On 2016/05/16 22:57:31, commit-bot: I haz the power wrote: > Failed to apply the patch. ...
4 years, 7 months ago (2016-05-16 23:01:02 UTC) #5
Tom Sepez
4 years, 7 months ago (2016-05-16 23:01:02 UTC) #6
On 2016/05/16 22:57:31, commit-bot: I haz the power wrote:
> Failed to apply the patch.

Beat you to it :).

Powered by Google App Engine
This is Rietveld 408576698