testing/libfuzzer/pdf_xml_fuzzer.cc - Issue 1980223002: Revert of Replace Release() { delete this; } in fde_xml_imp.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/libfuzzer/pdf_xml_fuzzer.cc

Issue 1980223002: Revert of Replace Release() { delete this; } in fde_xml_imp.h (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: testing/libfuzzer/pdf_xml_fuzzer.cc

diff --git a/testing/libfuzzer/pdf_xml_fuzzer.cc b/testing/libfuzzer/pdf_xml_fuzzer.cc

index 302b9a9d2f930ecc8602cdb35e28064b1704ca0f..ebafab374a9270960c8bd58a116113d04f32b213 100644

--- a/testing/libfuzzer/pdf_xml_fuzzer.cc

+++ b/testing/libfuzzer/pdf_xml_fuzzer.cc

@@ -55,7 +55,7 @@

return 0;

std::unique_ptr<CFDE_XMLDoc> doc(new CFDE_XMLDoc);

- std::unique_ptr<IFDE_XMLParser> parser(

+ std::unique_ptr<CFDE_XMLParser, ReleaseDeleter<CFDE_XMLParser>> parser(

new CXFA_XMLParser(doc->GetRoot(), stream.get()));

if (!doc->LoadXML(parser.release()))

« no previous file with comments | « no previous file | xfa/fde/xml/fde_xml_imp.h » ('j') | no next file with comments »