appengine/findit/crash/findit_for_crash.py - Issue 1980203002: [Findit] Filter inline function path frames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/crash/findit_for_crash.py

Issue 1980203002: [Findit] Filter inline function path frames (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Rebase and fix nits. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/findit/crash/findit_for_crash.py

diff --git a/appengine/findit/crash/findit_for_crash.py b/appengine/findit/crash/findit_for_crash.py

index 4d29124181819804b36d758592cac9b630911538..9a8249313211deae155518aff243606e5c0137e8 100644

--- a/appengine/findit/crash/findit_for_crash.py

+++ b/appengine/findit/crash/findit_for_crash.py

@@ -235,7 +235,7 @@ def FindItForCrash(stacktrace, regression_deps_rolls, crashed_deps):

# We are only interested in the deps in crash stack (the callstack that

# caused the crash).

- stack_deps = GetDepsInCrashStack(stacktrace.GetCrashStack(), crashed_deps)

+ stack_deps = GetDepsInCrashStack(stacktrace.crash_stack, crashed_deps)

# Get dep and file to changelogs, stack_info and blame dicts.

dep_to_file_to_changelogs, ignore_cls = GetChangeLogsForFilesGroupedByDeps(

« no previous file with comments | « appengine/findit/crash/callstack_filters.py ('k') | appengine/findit/crash/fracas_parser.py » ('j') | no next file with comments »