Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1998)

Unified Diff: appengine/findit/crash/callstack.py

Issue 1980203002: [Findit] Filter inline function path frames (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/callstack.py
diff --git a/appengine/findit/crash/callstack.py b/appengine/findit/crash/callstack.py
index 73c9eb3c57cd7a3b6e022214e3015c1119d22820..a0a81529d93a442a21bd5bb0665e98980377f394 100644
--- a/appengine/findit/crash/callstack.py
+++ b/appengine/findit/crash/callstack.py
@@ -78,9 +78,13 @@ class CallStack(list):
'#0 0x32b5982 in get third_party/WebKit/Source/wtf/RefPtr.h:61:43'
language_type (CallStackLanguageType): Either CPP or JAVA language.
"""
- def __init__(self, stack_priority, format_type=CallStackFormatType.DEFAULT):
- super(CallStack, self).__init__()
- self.priority = stack_priority
+ def __init__(self, priority, format_type=CallStackFormatType.DEFAULT,
+ frame_list=None):
+ if frame_list is None:
+ frame_list = []
+
+ super(CallStack, self).__init__(frame_list)
stgao 2016/05/17 00:30:34 This seems addressed in the other CL. You may wan
Sharu Jiang 2016/05/17 18:34:58 Since that was committed, I just do a rebase :)
+ self.priority = priority
self.format_type = format_type
self.language_type = parse_util.GetLanguageTypeFromFormatType(format_type)
« no previous file with comments | « no previous file | appengine/findit/crash/callstack_filters.py » ('j') | appengine/findit/crash/callstack_filters.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698