Introduce kRegisterSize, kPCOnStackSize and kFPOnStackSize constants

Introduce kRegisterSize, kPCOnStackSize and kFPOnStackSize constants

BUG=None
R=danno@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=15829

[haitao.feng, 2013-07-19 11:39:14]

This is migrated from https://codereview.chromium.org/19748003/.

[haitao.feng, 2013-07-22 13:36:01]

danno, could you give a lgtm to this one? I will use these constants to abstract
the X32 codes further.

[danno, 2013-07-22 21:35:16]

https://codereview.chromium.org/19802002/diff/1/src/deoptimizer.cc
File src/deoptimizer.cc (right):

https://codereview.chromium.org/19802002/diff/1/src/deoptimizer.cc#newcode1268
src/deoptimizer.cc:1268: unsigned fixed_frame_entries =
(kPCOnStackSize/kPointerSize) +
nit here and on following line: spaces left and right of the "/"

https://codereview.chromium.org/19802002/diff/1/src/deoptimizer.h
File src/deoptimizer.h (right):

https://codereview.chromium.org/19802002/diff/1/src/deoptimizer.h#newcode476
src/deoptimizer.h:476: virtual ~FrameDescription() { }
No need to make the destructor virtual if there are no virtual methods (see
below)

https://codereview.chromium.org/19802002/diff/1/src/deoptimizer.h#newcode514
src/deoptimizer.h:514: virtual void SetCallerPc(unsigned offset, intptr_t
value);
There is no need to make this function or the following one virtual. There is a
single implementation for each platform, there is no need for dynamic dispatch.

[haitao.feng, 2013-07-23 01:57:16]

Thanks for the review.

https://codereview.chromium.org/19802002/diff/1/src/deoptimizer.cc
File src/deoptimizer.cc (right):

https://codereview.chromium.org/19802002/diff/1/src/deoptimizer.cc#newcode1268
src/deoptimizer.cc:1268: unsigned fixed_frame_entries =
(kPCOnStackSize/kPointerSize) +
On 2013/07/22 21:35:16, danno wrote:
> nit here and on following line: spaces left and right of the "/"

Done.

https://codereview.chromium.org/19802002/diff/1/src/deoptimizer.h
File src/deoptimizer.h (right):

https://codereview.chromium.org/19802002/diff/1/src/deoptimizer.h#newcode476
src/deoptimizer.h:476: virtual ~FrameDescription() { }
On 2013/07/22 21:35:16, danno wrote:
> No need to make the destructor virtual if there are no virtual methods (see
> below) 

Done.

https://codereview.chromium.org/19802002/diff/1/src/deoptimizer.h#newcode514
src/deoptimizer.h:514: virtual void SetCallerPc(unsigned offset, intptr_t
value);
On 2013/07/22 21:35:16, danno wrote:
> There is no need to make this function or the following one virtual. There is
a
> single implementation for each platform, there is no need for dynamic
dispatch.

Done.

[danno, 2013-07-23 12:34:53]

lgtm

[haitao.feng, 2013-07-23 13:47:44]

Committed patchset #2 manually as r15829 (presubmit successful).