Introduce kRegisterSize, kPCOnStackSize and kFPOnStackSize constants

Introduce kRegisterSize, kPCOnStackSize and kFPOnStackSize constants

[haitao.feng, 2013-07-18 08:42:51]

Those constants will help introduce X32 port.  They are from danno's comments on
https://codereview.chromium.org/18014003/.

kRegisterSize will be kPointerSize + kPointerSize for X32.

[danno, 2013-07-18 10:51:23]

https://codereview.chromium.org/19748003/diff/1/src/deoptimizer.h
File src/deoptimizer.h (right):

https://codereview.chromium.org/19748003/diff/1/src/deoptimizer.h#newcode513
src/deoptimizer.h:513: void SetCallerPc(unsigned offset, intptr_t value) {
A difference copy of this routine should be in the platform-specific files.

https://codereview.chromium.org/19748003/diff/1/src/deoptimizer.h#newcode516
src/deoptimizer.h:516: SetFrameSlot(offset + kPointerSize, 0);
This assumes little endianess, I would much prefer to just have a different copy
of this short routine on each platform.

https://codereview.chromium.org/19748003/diff/1/src/deoptimizer.h#newcode521
src/deoptimizer.h:521: void SetCallerFp(unsigned offset, intptr_t value) {
Same as above, there should be a different implementation of this function in
each deoptimizer-XXX file for each platform.

[haitao.feng, 2013-07-18 12:18:20]

Thanks for the review. Comments addressed.

https://codereview.chromium.org/19748003/diff/1/src/deoptimizer.h
File src/deoptimizer.h (right):

https://codereview.chromium.org/19748003/diff/1/src/deoptimizer.h#newcode513
src/deoptimizer.h:513: void SetCallerPc(unsigned offset, intptr_t value) {
On 2013/07/18 10:51:24, danno wrote:
> A difference copy of this routine should be in the platform-specific files.

Done.

https://codereview.chromium.org/19748003/diff/1/src/deoptimizer.h#newcode516
src/deoptimizer.h:516: SetFrameSlot(offset + kPointerSize, 0);
On 2013/07/18 10:51:24, danno wrote:
> This assumes little endianess, I would much prefer to just have a different
copy
> of this short routine on each platform. 

Done.

https://codereview.chromium.org/19748003/diff/1/src/deoptimizer.h#newcode521
src/deoptimizer.h:521: void SetCallerFp(unsigned offset, intptr_t value) {
On 2013/07/18 10:51:24, danno wrote:
> Same as above, there should be a different implementation of this function in
> each deoptimizer-XXX file for each platform.

Done.

[danno, 2013-07-18 12:55:04]

lgtm if all tests pass on ia32, x64 and ARM.

[haitao.feng, 2013-07-18 13:17:13]

On my machine, 100% pass when make [ia32|x64|arm].release.check -j8.

[haitao.feng, 2013-07-19 11:40:09]

This CL is migrated to https://codereview.chromium.org/19802002/.