Issue 19800003: Output mini_installer_exe_version.rc to PRODUCT_DIR

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19800003: Output mini_installer_exe_version.rc to PRODUCT_DIR (Closed)

Created:
7 years, 5 months ago by jschuh

Modified:
7 years, 5 months ago

Reviewers:
Michael Moss, grt (UTC plus 2)

CC:
chromium-reviews, grt+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Output mini_installer_exe_version.rc to PRODUCT_DIR This is needed to fix hardcoded paths in FILES.CFG that prevent using ninja for official builds. BUG=262193 TBR=grt@chromium.org, mmoss@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212954

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	chrome/installer/mini_installer.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/tools/build/win/FILES.cfg	View		1 chunk	+1 line, -4 lines	0 comments	Download

Total messages: 6 (0 generated)

jschuh

The last one got reverted because the implicit dependency on the copy is apparently not ...

7 years, 5 months ago (2013-07-22 17:46:40 UTC) #1

jschuh

@grt - Since you approved the meat of this change in the previous CL and ...

7 years, 5 months ago (2013-07-22 19:11:19 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/19800003/1

7 years, 5 months ago (2013-07-22 19:12:10 UTC) #4

jschuh

7 years, 5 months ago (2013-07-22 20:16:37 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 manually as r212954 (presubmit successful).