Correctly set -stdlib=libc++ when building with a custom libc++.

Correctly set -stdlib=libc++ when building with a custom libc++.

The libcxx_proxy target used to set the link-time configuration to
correctly link libc++ sets it as a public_config. However, the sanitizer
deps targets have only private dependencies on libcxx_proxy so the
config does not apply to their dependents. This changes those
dependencies to be public.

This disables sanitizers for all non-default gcc_toolchain toolchains;
the android host toolchain build does not support building with libc++
and the GYP build does not use sanitizers for building host targets.

BUG=573288
Committed: https://crrev.com/34099cc1fb570af8990d5fad1b1e11fe4290680b
Cr-Commit-Position: refs/heads/master@{#394910}

[Sam McNally, 2016-05-16 08:18:47]

Description was changed from

==========
Correctly set -stdlib=libc++ when building with sanitizers.

The libcxx_proxy target used to set the link-time configuration to
correctly link libc++ sets it as a public_config. However, the sanitizer
deps targets have only private dependencies on libcxx_proxy so the
config does not apply to their dependents. This changes those
dependencies to be public.

BUG=573288
==========

to

==========
Correctly set -stdlib=libc++ when building with a custom libc++.

The libcxx_proxy target used to set the link-time configuration to
correctly link libc++ sets it as a public_config. However, the sanitizer
deps targets have only private dependencies on libcxx_proxy so the
config does not apply to their dependents. This changes those
dependencies to be public.

BUG=573288
==========

[Sam McNally, 2016-05-16 08:18:53]

Description was changed from

==========
Correctly set -stdlib=libc++ when building with a custom libc++.

The libcxx_proxy target used to set the link-time configuration to
correctly link libc++ sets it as a public_config. However, the sanitizer
deps targets have only private dependencies on libcxx_proxy so the
config does not apply to their dependents. This changes those
dependencies to be public.

BUG=573288
==========

to

==========
Correctly set -stdlib=libc++ when building with a custom libc++.

The libcxx_proxy target used to set the link-time configuration to
correctly link libc++ sets it as a public_config. However, the sanitizer
deps targets have only private dependencies on libcxx_proxy so the
config does not apply to their dependents. This changes those
dependencies to be public.

BUG=573288
==========

[Sam McNally, 2016-05-16 08:20:43]

sammc@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-05-16 17:36:06]

lgtm, I think. +thakis ...

[Nico, 2016-05-16 17:38:33]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-05-16 17:38:33]

Makes sense, thanks!

[Sam McNally, 2016-05-17 08:01:49]

That one red trybot found quite a few issues with using asan with gn on android:
1. The wrong path is added to lib_dirs for non-default toolchains (fixing in
https://codereview.chromium.org/1984953002/)

2. Host shared libraries use a .cr.so extension when building component builds
for android. I'm not really happy with my fix for this so I'd welcome
alternative suggestions. The underlying problem is that toolchain.gni is
imported under the default toolchain when creating all toolchains so they all
end up with .cr.so, but the non-default toolchains should pick up the value of
shlib_extension set according to the arguments set by their toolchain_args()
blocks.

3. android_protobuf doesn't build with sanitizers so it also depends on
libstdc++ which is no longer be linked after this CL. My workaround for this is
to use a custom config.h which assumes C++11 instead of TR1 so it can build with
libc++ and build it with sanitizers enabled.

An alternative to these changes would be to disable sanitizers for non-default
toolchains in this CL and deal with these issues later.

[Nico, 2016-05-19 00:34:34]

Do you know how this worked in gyp? Can we do here what we did there?

[Sam McNally, 2016-05-19 04:27:19]

On 2016/05/19 00:34:34, Nico (vacation May 19 to 22) wrote:
> Do you know how this worked in gyp? Can we do here what we did there?

It turns out that custom libc++ isn't used for android asan and sanitizers
aren't used for host targets with gyp.

We can do the former (it seems worthwhile for consistency with gyp), but it
wouldn't affect the host Linux toolchain. For the latter, we could disable
propagating sanitizer options for all gcc_toolchain toolchains; this would
disable sanitizers for targets built with the host toolchain for android builds.

[Dirk Pranke, 2016-05-19 05:17:26]

lgtm.

https://codereview.chromium.org/1979973002/diff/40001/build/config/sanitizers...
File build/config/sanitizers/sanitizers.gni (right):

https://codereview.chromium.org/1979973002/diff/40001/build/config/sanitizers...
build/config/sanitizers/sanitizers.gni:84: (is_asan && is_linux && !is_android
&& !is_chromeos) || is_tsan ||
you shouldn't need !is_android here; is_linux implies !is_android.

[Sam McNally, 2016-05-19 07:16:55]

Description was changed from

==========
Correctly set -stdlib=libc++ when building with a custom libc++.

The libcxx_proxy target used to set the link-time configuration to
correctly link libc++ sets it as a public_config. However, the sanitizer
deps targets have only private dependencies on libcxx_proxy so the
config does not apply to their dependents. This changes those
dependencies to be public.

BUG=573288
==========

to

==========
Correctly set -stdlib=libc++ when building with a custom libc++.

The libcxx_proxy target used to set the link-time configuration to
correctly link libc++ sets it as a public_config. However, the sanitizer
deps targets have only private dependencies on libcxx_proxy so the
config does not apply to their dependents. This changes those
dependencies to be public.

This disables sanitizers for all non-default gcc_toolchain toolchains;
the android host toolchain build does not support building with libc++
and the GYP build does not use sanitizers for building host targets.

BUG=573288
==========

[Sam McNally, 2016-05-19 07:37:53]

Patchset #5 (id:80001) has been deleted

[Sam McNally, 2016-05-19 07:38:06]

https://codereview.chromium.org/1979973002/diff/40001/build/config/sanitizers...
File build/config/sanitizers/sanitizers.gni (right):

https://codereview.chromium.org/1979973002/diff/40001/build/config/sanitizers...
build/config/sanitizers/sanitizers.gni:84: (is_asan && is_linux && !is_android
&& !is_chromeos) || is_tsan ||
On 2016/05/19 05:17:26, Dirk Pranke wrote:
> you shouldn't need !is_android here; is_linux implies !is_android.

Done.

[Sam McNally, 2016-05-19 23:46:35]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2016-05-19 23:46:35]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1979973002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-05-19 23:47:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1979973002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1979973002/60001

[commit-bot: I haz the power, 2016-05-19 23:53:22]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-19 23:54:37]

Description was changed from

==========
Correctly set -stdlib=libc++ when building with a custom libc++.

The libcxx_proxy target used to set the link-time configuration to
correctly link libc++ sets it as a public_config. However, the sanitizer
deps targets have only private dependencies on libcxx_proxy so the
config does not apply to their dependents. This changes those
dependencies to be public.

This disables sanitizers for all non-default gcc_toolchain toolchains;
the android host toolchain build does not support building with libc++
and the GYP build does not use sanitizers for building host targets.

BUG=573288
==========

to

==========
Correctly set -stdlib=libc++ when building with a custom libc++.

The libcxx_proxy target used to set the link-time configuration to
correctly link libc++ sets it as a public_config. However, the sanitizer
deps targets have only private dependencies on libcxx_proxy so the
config does not apply to their dependents. This changes those
dependencies to be public.

This disables sanitizers for all non-default gcc_toolchain toolchains;
the android host toolchain build does not support building with libc++
and the GYP build does not use sanitizers for building host targets.

BUG=573288

Committed: https://crrev.com/34099cc1fb570af8990d5fad1b1e11fe4290680b
Cr-Commit-Position: refs/heads/master@{#394910}
==========

[commit-bot: I haz the power, 2016-05-19 23:54:39]

Patchset 4 (id:??) landed as
https://crrev.com/34099cc1fb570af8990d5fad1b1e11fe4290680b
Cr-Commit-Position: refs/heads/master@{#394910}