Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: build/config/sanitizers/BUILD.gn

Issue 1979973002: Correctly set -stdlib=libc++ when building with a custom libc++. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/sanitizers/sanitizers.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/sanitizers/BUILD.gn
diff --git a/build/config/sanitizers/BUILD.gn b/build/config/sanitizers/BUILD.gn
index ba3ba3fa263042b4032248941e7441efe7994a51..3160bce94f146c0a250822852f637bb4d4bbd5f9 100644
--- a/build/config/sanitizers/BUILD.gn
+++ b/build/config/sanitizers/BUILD.gn
@@ -11,7 +11,7 @@ import("//build/toolchain/toolchain.gni")
# shared_libraries. Unconditionally depend upon this target as it is empty if
# |is_asan|, |is_lsan|, |is_tsan|, |is_msan| and |use_custom_libcxx| are false.
group("deps") {
- deps = [
+ public_deps = [
":deps_no_options",
]
if (using_sanitizer) {
@@ -23,7 +23,9 @@ group("deps") {
# to add the ldflags here as well as in default_sanitizer_flags.
":default_sanitizer_ldflags",
]
- deps += [ ":options_sources" ]
+ deps = [
+ ":options_sources",
+ ]
}
}
@@ -40,7 +42,9 @@ group("deps_no_options") {
deps += [ "//third_party/instrumented_libraries:deps" ]
}
if (use_custom_libcxx) {
- deps += [ "//buildtools/third_party/libc++:libcxx_proxy" ]
+ public_deps = [
+ "//buildtools/third_party/libc++:libcxx_proxy",
+ ]
}
if (is_mac) {
data_deps = [
« no previous file with comments | « no previous file | build/config/sanitizers/sanitizers.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698