third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py - Issue 1979963002: Remove OwnPtr::release() calls in platform/ (part inspector).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py

Issue 1979963002: Remove OwnPtr::release() calls in platform/ (part inspector). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/Array.h ('k') | third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_cpp.template » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py b/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py

index fc4abe5bf6efabee11a49be69297a70bbfc00b18..3f82c1f4d336f8dcda4c03ee9c4ddb056d41169a 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py

+++ b/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py

@@ -110,7 +110,7 @@ def create_user_type_definition(domain_name, type):

"return_type": "PassOwnPtr<protocol::%s::%s>" % (domain_name, type["id"]),

"pass_type": "PassOwnPtr<protocol::%s::%s>" % (domain_name, type["id"]),

"to_raw_type": "%s.get()",

- "to_pass_type": "%s.release()",

+ "to_pass_type": "std::move(%s)",

"to_rvalue": "std::move(%s)",

"type": "OwnPtr<protocol::%s::%s>" % (domain_name, type["id"]),

"raw_type": "protocol::%s::%s" % (domain_name, type["id"]),

@@ -124,7 +124,7 @@ def create_object_type_definition():

"return_type": "PassOwnPtr<protocol::DictionaryValue>",

"pass_type": "PassOwnPtr<protocol::DictionaryValue>",

"to_raw_type": "%s.get()",

- "to_pass_type": "%s.release()",

+ "to_pass_type": "std::move(%s)",

"to_rvalue": "std::move(%s)",

"type": "OwnPtr<protocol::DictionaryValue>",

"raw_type": "protocol::DictionaryValue",

@@ -138,7 +138,7 @@ def create_any_type_definition():

"return_type": "PassOwnPtr<protocol::Value>",

"pass_type": "PassOwnPtr<protocol::Value>",

"to_raw_type": "%s.get()",

- "to_pass_type": "%s.release()",

+ "to_pass_type": "std::move(%s)",

"to_rvalue": "std::move(%s)",

"type": "OwnPtr<protocol::Value>",

"raw_type": "protocol::Value",

@@ -208,7 +208,7 @@ def wrap_array_definition(type):

"return_type": "PassOwnPtr<protocol::Array<%s>>" % type["raw_type"],

"pass_type": "PassOwnPtr<protocol::Array<%s>>" % type["raw_type"],

"to_raw_type": "%s.get()",

- "to_pass_type": "%s.release()",

+ "to_pass_type": "std::move(%s)",

"to_rvalue": "std::move(%s)",

"type": "OwnPtr<protocol::Array<%s>>" % type["raw_type"],

"raw_type": "protocol::Array<%s>" % type["raw_type"],