Print Preview: Get printer info with capabilities.

Print Preview: Get printer info with capabilities.

When getting the printer capabilities, also get the basic printer info.
Properly parse the printer info and display it to the user in the
destination field in print preview.

BUG=132831, 347258
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/27bb2f801450444360e43e260939560c01412431
Cr-Commit-Position: refs/heads/master@{#393964}

[Lei Zhang, 2016-05-15 07:25:44]

Description was changed from

==========
Print Preview: Get printer info with capabilities.

When getting the printer capabilities, also get the basic printer info.
Properly parse the printer info and display it to the user in the
destination field in print preview.

BUG=132831,347258
==========

to

==========
Print Preview: Get printer info with capabilities.

When getting the printer capabilities, also get the basic printer info.
Properly parse the printer info and display it to the user in the
destination field in print preview.

BUG=132831,347258
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Lei Zhang, 2016-05-15 08:41:24]

Patchset #1 (id:1) has been deleted

[Lei Zhang, 2016-05-16 18:48:19]

thestig@chromium.org changed reviewers:
+ dpapad@chromium.org

[dpapad, 2016-05-16 21:11:43]

lgtm

https://codereview.chromium.org/1979903002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right):

https://codereview.chromium.org/1979903002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:1321:
printer_name_value);
Nit (optional): Inline printer_name_value
web_ui()->CallJavascriptFunction("failedToGetPrinterCapabilities",
                                 base::StringValue(printer_name));

[Lei Zhang, 2016-05-16 21:27:09]

https://codereview.chromium.org/1979903002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right):

https://codereview.chromium.org/1979903002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:1321:
printer_name_value);
On 2016/05/16 21:11:43, dpapad wrote:
> Nit (optional): Inline printer_name_value
> web_ui()->CallJavascriptFunction("failedToGetPrinterCapabilities",
>                                  base::StringValue(printer_name));

Done.

[Lei Zhang, 2016-05-16 21:40:02]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-05-16 21:40:02]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/1979903002/#ps40001
(title: "nit")

[commit-bot: I haz the power, 2016-05-16 21:40:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1979903002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1979903002/40001

[commit-bot: I haz the power, 2016-05-16 22:58:07]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-05-16 22:59:31]

Description was changed from

==========
Print Preview: Get printer info with capabilities.

When getting the printer capabilities, also get the basic printer info.
Properly parse the printer info and display it to the user in the
destination field in print preview.

BUG=132831,347258
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Print Preview: Get printer info with capabilities.

When getting the printer capabilities, also get the basic printer info.
Properly parse the printer info and display it to the user in the
destination field in print preview.

BUG=132831,347258
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/27bb2f801450444360e43e260939560c01412431
Cr-Commit-Position: refs/heads/master@{#393964}
==========

[commit-bot: I haz the power, 2016-05-16 22:59:32]

Patchset 2 (id:??) landed as
https://crrev.com/27bb2f801450444360e43e260939560c01412431
Cr-Commit-Position: refs/heads/master@{#393964}