Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 1976683005: Use cupsGetNamedDest() in PrintBackendCUPS. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
dpapad
CC:
chromium-reviews, skau
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use cupsGetNamedDest() in PrintBackendCUPS. Older OS X versions have been deprecated. It is safe to assume all clients have a newer version of CUPS. Do some cleanups as well. Committed: https://crrev.com/3154ea2506e28554bf687f9afc551335f7b3458f Cr-Commit-Position: refs/heads/master@{#393937}

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -45 lines) Patch
M printing/backend/print_backend_cups.cc View 12 chunks +47 lines, -45 lines 1 comment Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
Lei Zhang
https://codereview.chromium.org/1976683005/diff/20001/printing/backend/print_backend_cups.cc File printing/backend/print_backend_cups.cc (right): https://codereview.chromium.org/1976683005/diff/20001/printing/backend/print_backend_cups.cc#newcode48 printing/backend/print_backend_cups.cc:48: // The following functions are wrappers around corresponding CUPS ...
4 years, 7 months ago (2016-05-16 18:43:18 UTC) #4
Lei Zhang
+skau FYI
4 years, 7 months ago (2016-05-16 18:44:51 UTC) #5
dpapad
lgtm
4 years, 7 months ago (2016-05-16 20:49:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976683005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976683005/20001
4 years, 7 months ago (2016-05-16 20:50:29 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-16 21:34:14 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 21:35:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3154ea2506e28554bf687f9afc551335f7b3458f
Cr-Commit-Position: refs/heads/master@{#393937}

Powered by Google App Engine
This is Rietveld 408576698