Remove C::swap(C*) where C = Hash{Map,Set}<T>.

Remove C::swap(C*) where C = Hash{Map,Set}<T>.

Remove the swap() method over non-reference hash sets and
map arguments, along with their curious OtherType indirection,
the methods aren't of real use.

R=
BUG=

Committed: https://crrev.com/79c00d4fb5f5afb20ea12b88e9ce7ecae5f79f33
Cr-Commit-Position: refs/heads/master@{#393770}

[sof, 2016-05-15 06:45:04]

Description was changed from

==========
Remove unnecessary Allocator::OtherType indirection.

It always expands to T* ?

R=
BUG=
==========

to

==========
Remove C::swap(C*) where C = Hash{Map,Set}<T>.

Remove the swap() method over non-reference hash sets and
map arguments, along with their curious OtherType indirection,
the methods aren't of real use.

R=
BUG=
==========

[sof, 2016-05-15 06:52:20]

sigbjornf@opera.com changed reviewers:
+ haraken@chromium.org, tkent@chromium.org

[sof, 2016-05-15 06:52:21]

please take a look.

The introduction of these methods and OtherType comes from
https://codereview.chromium.org/131803005/ - I'm failing to understand the need
for OtherType, then or now, but in any case the swap() methods do not have
significant use.

[haraken, 2016-05-15 08:08:30]

LGTM

[sof, 2016-05-15 08:38:24]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-05-15 08:38:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1979843002/40002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1979843002/40002

[commit-bot: I haz the power, 2016-05-15 10:26:05]

Description was changed from

==========
Remove C::swap(C*) where C = Hash{Map,Set}<T>.

Remove the swap() method over non-reference hash sets and
map arguments, along with their curious OtherType indirection,
the methods aren't of real use.

R=
BUG=
==========

to

==========
Remove C::swap(C*) where C = Hash{Map,Set}<T>.

Remove the swap() method over non-reference hash sets and
map arguments, along with their curious OtherType indirection,
the methods aren't of real use.

R=
BUG=
==========

[commit-bot: I haz the power, 2016-05-15 10:26:06]

Committed patchset #4 (id:40002)

[commit-bot: I haz the power, 2016-05-15 10:28:09]

Description was changed from

==========
Remove C::swap(C*) where C = Hash{Map,Set}<T>.

Remove the swap() method over non-reference hash sets and
map arguments, along with their curious OtherType indirection,
the methods aren't of real use.

R=
BUG=
==========

to

==========
Remove C::swap(C*) where C = Hash{Map,Set}<T>.

Remove the swap() method over non-reference hash sets and
map arguments, along with their curious OtherType indirection,
the methods aren't of real use.

R=
BUG=

Committed: https://crrev.com/79c00d4fb5f5afb20ea12b88e9ce7ecae5f79f33
Cr-Commit-Position: refs/heads/master@{#393770}
==========

[commit-bot: I haz the power, 2016-05-15 10:28:10]

Patchset 4 (id:??) landed as
https://crrev.com/79c00d4fb5f5afb20ea12b88e9ce7ecae5f79f33
Cr-Commit-Position: refs/heads/master@{#393770}