Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: third_party/WebKit/Source/platform/heap/HeapTest.cpp

Issue 1979843002: Remove C::swap(C*) where C = Hash{Map,Set}<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: HeapTest compile fixes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/heap/HeapAllocator.h ('k') | third_party/WebKit/Source/wtf/HashMap.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/HeapTest.cpp
diff --git a/third_party/WebKit/Source/platform/heap/HeapTest.cpp b/third_party/WebKit/Source/platform/heap/HeapTest.cpp
index 0e6147d866af2f9fe23a6f33b467ce4add982ca7..5adcc2bb7161094a3f38d5e17c318a8c8f9d3fe5 100644
--- a/third_party/WebKit/Source/platform/heap/HeapTest.cpp
+++ b/third_party/WebKit/Source/platform/heap/HeapTest.cpp
@@ -2779,7 +2779,7 @@ TEST(HeapTest, HeapCollectionTypes)
set2->swap(cset2);
set->swap(cset2);
cset1.swap(cset2);
- cset2.swap(set2);
+ cset2.swap(*set2);
MemberCountedSet& cCountedSet = container->set3;
set3->swap(cCountedSet);
@@ -2787,10 +2787,10 @@ TEST(HeapTest, HeapCollectionTypes)
set3->swap(cCountedSet);
// Triple swap.
- container->map.swap(memberMember2);
+ container->map.swap(*memberMember2);
MemberMember& containedMap = container->map;
memberMember3->swap(containedMap);
- memberMember3->swap(memberMember);
+ memberMember3->swap(*memberMember);
EXPECT_TRUE(memberMember->get(one) == two);
EXPECT_TRUE(memberMember->get(two) == three);
« no previous file with comments | « third_party/WebKit/Source/platform/heap/HeapAllocator.h ('k') | third_party/WebKit/Source/wtf/HashMap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698