Remove security_origin member from content::Stream.

Remove security_origin member from content::Stream.

Stream::security_origin_ is not used at all for now. There's no
established code in Chromium to do origin checking. Security of
Blob/Stream resource loading now depends on origin checking
mechanism in Blink.

Keeping this variable without having any checking mechanism
confuses developers. Remove it until we build origin checking code
in Chromium.

Also, rename security_origin to origin, as it's nothing but an origin
URL.

BUG=263342
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213830

[kinuko, 2013-07-24 09:01:32]

Looks reasonable, lgtm

[Tom Sepez, 2013-07-24 16:49:50]

On 2013/07/24 09:01:32, kinuko wrote:
> Looks reasonable, lgtm

OK for now, adding creis@ as this will impact the site integrity work. We are
going to need a way for the browser to know the origin associated with a stream
without being told by the renderer.  It can then lookup whether there is
permission for that origin in ChildProcessSecurityPolicy[Impl].

[jam, 2013-07-24 18:08:21]

did you mean to add creis instead of me as a reviewer? lgtm either way

[Charlie Reis, 2013-07-24 20:33:20]

LGTM.  Thanks for the heads up, Tom.  We'll definitely revisit this when
renderer processes can be restricted to a particular site, but I agree that it's
not useful until then.

https://codereview.chromium.org/19798012/diff/2001/content/browser/streams/st...
File content/browser/streams/stream.h (right):

https://codereview.chromium.org/19798012/diff/2001/content/browser/streams/st...
content/browser/streams/stream.h:41: // Creates a stream.
Can you add something about the security origin check being done in Blink?  That
will help us track this down when we want to add a browser-side check later.

[tyoshino (SeeGerritForStatus), 2013-07-25 03:27:59]

thanks reviewers

https://codereview.chromium.org/19798012/diff/2001/content/browser/streams/st...
File content/browser/streams/stream.h (right):

https://codereview.chromium.org/19798012/diff/2001/content/browser/streams/st...
content/browser/streams/stream.h:41: // Creates a stream.
On 2013/07/24 20:33:21, creis wrote:
> Can you add something about the security origin check being done in Blink? 
That
> will help us track this down when we want to add a browser-side check later.

Done.

[tyoshino (SeeGerritForStatus), 2013-07-25 03:53:34]

Forgot to fix unittests. It's just removing GURL() from parameters. Done

[commit-bot: I haz the power, 2013-07-25 03:56:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tyoshino@chromium.org/19798012/15001

[commit-bot: I haz the power, 2013-07-25 13:34:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tyoshino@chromium.org/19798012/15001

[commit-bot: I haz the power, 2013-07-26 01:21:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tyoshino@chromium.org/19798012/15001

[commit-bot: I haz the power, 2013-07-26 10:54:38]

Change committed as 213830