Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: content/public/browser/resource_dispatcher_host_delegate.h

Issue 19798012: Remove security_origin member from content::Stream. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed unittests Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/resource_dispatcher_host_delegate.h
diff --git a/content/public/browser/resource_dispatcher_host_delegate.h b/content/public/browser/resource_dispatcher_host_delegate.h
index af56b73ee70b78d8220fed41d627261c80a6624a..95e336bb9bc8e07ac0c9c7d5bb1cab7ab0fd83b1 100644
--- a/content/public/browser/resource_dispatcher_host_delegate.h
+++ b/content/public/browser/resource_dispatcher_host_delegate.h
@@ -108,23 +108,25 @@ class CONTENT_EXPORT ResourceDispatcherHostDelegate {
virtual bool ShouldForceDownloadResource(
const GURL& url, const std::string& mime_type);
- // Returns true and sets |security_origin| and |target_id| if a Stream should
- // be created for the resource.
- // If true is returned, a new Stream will be created and OnStreamCreated will
- // be called with the |target_id| returned by this function and a URL to read
- // the Stream which is accessible from the |security_origin| returned by this
- // function.
+ // Returns true and sets |origin| and |target_id| if a Stream should be
+ // created for the resource.
+ // If true is returned, a new Stream will be created and OnStreamCreated()
+ // will be called with
+ // - the |target_id| returned by this function
+ // - a StreamHandle instance for the Stream. The handle contains the URL for
+ // reading the Stream etc.
+ // The Stream's origin will be set to |origin|.
virtual bool ShouldInterceptResourceAsStream(
content::ResourceContext* resource_context,
const GURL& url,
const std::string& mime_type,
- GURL* security_origin,
+ GURL* origin,
std::string* target_id);
- // Informs the delegate that a stream was created. |target_id| will be filled
+ // Informs the delegate that a Stream was created. |target_id| will be filled
// with the parameter returned by ShouldInterceptResourceAsStream(). The
- // Stream can be read from the blob URL owned by |stream|, but can only be
- // read once.
+ // Stream can be read from the blob URL of the Stream, but can only be read
+ // once.
virtual void OnStreamCreated(
content::ResourceContext* resource_context,
int render_process_id,

Powered by Google App Engine
This is Rietveld 408576698