Add an action to create a symbol file for the Blimp engine

Add an action to create a symbol file for the Blimp engine

This is modeled after what is done for the official Chrome linux build.
As it stands right now, the breakpad symbol file is roughly 300MB and
takes a couple of minutes to run, so the action should only be triggered
if this is an official release.

BUG=597454
Committed: https://crrev.com/060ef497fef78501475548ec61dbc8c290f02a9b
Cr-Commit-Position: refs/heads/master@{#394191}

[marcinjb, 2016-05-14 00:54:11]

marcinjb@chromium.org changed reviewers:
+ amineer@chromium.org, kmarshall@chromium.org

[marcinjb, 2016-05-14 00:54:12]

amineer: I just want to double check that when this runs on the official builder
that the "is_official_build" variable is set to true.

[Kevin M, 2016-05-16 17:32:34]

lgtm

[Kevin M, 2016-05-16 17:33:28]

kmarshall@chromium.org changed required reviewers:
+ amineer@chromium.org

[Kevin M, 2016-05-16 17:33:29]

Made amineer a mandatory reviewer because I don't know that portion of the build
system too well.

[marcinjb, 2016-05-16 22:17:28]

marcinjb@chromium.org changed reviewers:
+ dpranke@chromium.org

[marcinjb, 2016-05-16 22:17:28]

dpranke: Please check out the blimp-engine.gn changes

[amineer, 2016-05-16 22:17:51]

On 2016/05/16 22:17:28, marcinjb wrote:
> dpranke: Please check out the blimp-engine.gn changes

lgtm

[Dirk Pranke, 2016-05-16 23:50:23]

lgtm

https://codereview.chromium.org/1979773002/diff/20001/blimp/engine/BUILD.gn
File blimp/engine/BUILD.gn (right):

https://codereview.chromium.org/1979773002/diff/20001/blimp/engine/BUILD.gn#n...
blimp/engine/BUILD.gn:542: dump_syms_label =
"//breakpad:dump_syms($host_toolchain)"
($host_toolchain) is almost certainly unnecessary here, since the blimp_engine
will probably always be built w/ the host toolchain.

[marcinjb, 2016-05-17 17:49:31]

https://codereview.chromium.org/1979773002/diff/20001/blimp/engine/BUILD.gn
File blimp/engine/BUILD.gn (right):

https://codereview.chromium.org/1979773002/diff/20001/blimp/engine/BUILD.gn#n...
blimp/engine/BUILD.gn:542: dump_syms_label =
"//breakpad:dump_syms($host_toolchain)"
On 2016/05/16 23:50:23, Dirk Pranke wrote:
> ($host_toolchain) is almost certainly unnecessary here, since the blimp_engine
> will probably always be built w/ the host toolchain.

Ah, good to know.  Removed (this was basically a copy-paste from Chrome's where
$host_toolchain was probably necessary).

[marcinjb, 2016-05-17 17:49:41]

The CQ bit was checked by marcinjb@chromium.org

[marcinjb, 2016-05-17 17:49:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
kmarshall@chromium.org, dpranke@chromium.org, amineer@chromium.org
Link to the patchset: https://codereview.chromium.org/1979773002/#ps40001
(title: "Remove $host_toolchain")

[commit-bot: I haz the power, 2016-05-17 17:50:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1979773002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1979773002/40001

[commit-bot: I haz the power, 2016-05-17 19:37:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-17 19:41:25]

Description was changed from

==========
Add an action to create a symbol file for the Blimp engine

This is modeled after what is done for the official Chrome linux build.
As it stands right now, the breakpad symbol file is roughly 300MB and
takes a couple of minutes to run, so the action should only be triggered
if this is an official release.

BUG=597454
==========

to

==========
Add an action to create a symbol file for the Blimp engine

This is modeled after what is done for the official Chrome linux build.
As it stands right now, the breakpad symbol file is roughly 300MB and
takes a couple of minutes to run, so the action should only be triggered
if this is an official release.

BUG=597454

Committed: https://crrev.com/060ef497fef78501475548ec61dbc8c290f02a9b
Cr-Commit-Position: refs/heads/master@{#394191}
==========

[commit-bot: I haz the power, 2016-05-17 19:41:27]

Patchset 3 (id:??) landed as
https://crrev.com/060ef497fef78501475548ec61dbc8c290f02a9b
Cr-Commit-Position: refs/heads/master@{#394191}