Issue 1979743002: Rename the QUIC stream frame fields frame_buffer and frame_length to data_buffer and data_length be…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1979743002: Rename the QUIC stream frame fields frame_buffer and frame_length to data_buffer and data_length be… (Closed)

Created:
4 years, 7 months ago by Buck

Modified:
4 years, 7 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@121700577

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Rename the QUIC stream frame fields frame_buffer and frame_length to data_buffer and data_length because they do only contain info about the *data* not the full frame. Merge internal change: 121705514 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+79 lines, -79 lines)			Patch
M	net/quic/quic_connection.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_connection_logger.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_connection_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_framer.cc	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	net/quic/quic_framer_test.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	net/quic/quic_headers_stream_test.cc	View	12 chunks	+24 lines, -24 lines	0 comments	Download
M	net/quic/quic_packet_creator_test.cc	View	14 chunks	+15 lines, -15 lines	0 comments	Download
M	net/quic/quic_packet_generator.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_protocol.h	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	net/quic/quic_protocol.cc	View	2 chunks	+10 lines, -10 lines	0 comments	Download
M	net/quic/quic_session.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_stream_sequencer.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/quic/quic_stream_sequencer_test.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	net/quic/reliable_quic_stream.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/test_tools/crypto_test_utils.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/test_tools/simple_quic_framer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/tools/quic/chlo_extractor.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/tools/quic/quic_packet_printer_bin.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Depends on Patchset:

Issue 1980783002 Patch 1

Dependent Patchsets:

Issue 1979633003 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages