Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Side by Side Diff: net/quic/quic_connection_logger.cc

Issue 1979743002: Rename the QUIC stream frame fields frame_buffer and frame_length to data_buffer and data_length be… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@121700577
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/quic_connection.cc ('k') | net/quic/quic_connection_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_connection_logger.h" 5 #include "net/quic/quic_connection_logger.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 return std::move(dict); 97 return std::move(dict);
98 } 98 }
99 99
100 std::unique_ptr<base::Value> NetLogQuicStreamFrameCallback( 100 std::unique_ptr<base::Value> NetLogQuicStreamFrameCallback(
101 const QuicStreamFrame* frame, 101 const QuicStreamFrame* frame,
102 NetLogCaptureMode /* capture_mode */) { 102 NetLogCaptureMode /* capture_mode */) {
103 std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue()); 103 std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
104 dict->SetInteger("stream_id", frame->stream_id); 104 dict->SetInteger("stream_id", frame->stream_id);
105 dict->SetBoolean("fin", frame->fin); 105 dict->SetBoolean("fin", frame->fin);
106 dict->SetString("offset", base::Uint64ToString(frame->offset)); 106 dict->SetString("offset", base::Uint64ToString(frame->offset));
107 dict->SetInteger("length", frame->frame_length); 107 dict->SetInteger("length", frame->data_length);
108 return std::move(dict); 108 return std::move(dict);
109 } 109 }
110 110
111 std::unique_ptr<base::Value> NetLogQuicAckFrameCallback( 111 std::unique_ptr<base::Value> NetLogQuicAckFrameCallback(
112 const QuicAckFrame* frame, 112 const QuicAckFrame* frame,
113 NetLogCaptureMode /* capture_mode */) { 113 NetLogCaptureMode /* capture_mode */) {
114 std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue()); 114 std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
115 dict->SetString("largest_observed", 115 dict->SetString("largest_observed",
116 base::Uint64ToString(frame->largest_observed)); 116 base::Uint64ToString(frame->largest_observed));
117 dict->SetString("delta_time_largest_observed_us", 117 dict->SetString("delta_time_largest_observed_us",
(...skipping 756 matching lines...) Expand 10 before | Expand all | Expand 10 after
874 continue; 874 continue;
875 } 875 }
876 // Record some overlapping patterns, to get a better picture, since this is 876 // Record some overlapping patterns, to get a better picture, since this is
877 // not very expensive. 877 // not very expensive.
878 if (i % 3 == 0) 878 if (i % 3 == 0)
879 six_packet_histogram->Add(recent_6_mask); 879 six_packet_histogram->Add(recent_6_mask);
880 } 880 }
881 } 881 }
882 882
883 } // namespace net 883 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_connection.cc ('k') | net/quic/quic_connection_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698