Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1979513004: Add array traits for WTF::Vector. (Closed)

Created:
4 years, 7 months ago by yzshen1
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@28_array_native
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add array traits for WTF::Vector. With this traits, in blink code a StructTraits can directly return WTF::Vector from its field getters or read mojo arrays as WTF::Vectors from DataView. BUG=577686 Committed: https://crrev.com/a9ed6ac06479e1c77dfc9b596f93787e4ca7e993 Cr-Commit-Position: refs/heads/master@{#393584}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -2 lines) Patch
M mojo/mojo_public.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/bindings/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/cpp/bindings/array_traits_wtf_vector.h View 1 chunk +44 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/wtf_serialization.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/wtf_types_unittest.cc View 2 chunks +23 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years, 7 months ago (2016-05-13 17:04:20 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 7 months ago (2016-05-13 17:06:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979513004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979513004/1
4 years, 7 months ago (2016-05-13 17:35:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 18:14:15 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 18:16:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9ed6ac06479e1c77dfc9b596f93787e4ca7e993
Cr-Commit-Position: refs/heads/master@{#393584}

Powered by Google App Engine
This is Rietveld 408576698