Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1978003002: Mojo C++ bindings: add detailed comments for String/Array/StructTraits. (Closed)

Created:
4 years, 7 months ago by yzshen1
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@29_wtf_vector
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: add detailed comments for String/Array/StructTraits. BUG=577686 Committed: https://crrev.com/119a3bbf42cd7142bfd800cc37fa08b0a814ee7b Cr-Commit-Position: refs/heads/master@{#393693}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -19 lines) Patch
M mojo/public/cpp/bindings/array_traits.h View 1 2 1 chunk +25 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/array_traits_standard.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/string_traits.h View 1 2 2 chunks +36 lines, -5 lines 0 comments Download
M mojo/public/cpp/bindings/struct_traits.h View 1 1 chunk +83 lines, -8 lines 0 comments Download

Depends on Patchset:

Issue 1979513004 Patch 1

Messages

Total messages: 10 (4 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years, 7 months ago (2016-05-13 20:30:07 UTC) #2
Ken Rockot(use gerrit already)
Woohoo! lgtm https://codereview.chromium.org/1978003002/diff/20001/mojo/public/cpp/bindings/array_traits.h File mojo/public/cpp/bindings/array_traits.h (right): https://codereview.chromium.org/1978003002/diff/20001/mojo/public/cpp/bindings/array_traits.h#newcode21 mojo/public/cpp/bindings/array_traits.h:21: // // This two methods are optional. ...
4 years, 7 months ago (2016-05-13 20:40:46 UTC) #3
yzshen1
https://codereview.chromium.org/1978003002/diff/20001/mojo/public/cpp/bindings/array_traits.h File mojo/public/cpp/bindings/array_traits.h (right): https://codereview.chromium.org/1978003002/diff/20001/mojo/public/cpp/bindings/array_traits.h#newcode21 mojo/public/cpp/bindings/array_traits.h:21: // // This two methods are optional. Please see ...
4 years, 7 months ago (2016-05-13 20:47:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978003002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978003002/40001
4 years, 7 months ago (2016-05-13 20:48:45 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-13 23:52:14 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 23:53:58 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/119a3bbf42cd7142bfd800cc37fa08b0a814ee7b
Cr-Commit-Position: refs/heads/master@{#393693}

Powered by Google App Engine
This is Rietveld 408576698