third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h - Issue 1979493002: Remove OwnPtr::release() calls in bindings/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h

Issue 1979493002: Remove OwnPtr::release() calls in bindings/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h b/third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h

index 65e9b93019679b598ef0fdd77bd4bef7b80e6a00..ef7959d04aceb7199b0299a687bc699bbbdcbfe7 100644

--- a/third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h

+++ b/third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h

@@ -142,7 +142,7 @@ private:

template <typename T>

static PassOwnPtr<T> adopt(std::unique_ptr<T>& x) { return adoptPtr(x.release()); }

template <typename T> static PassType<T> pass(T& x) { return x; }

- template <typename T> static PassOwnPtr<T> pass(OwnPtr<T>& x) { return x.release(); }

+ template <typename T> static PassOwnPtr<T> pass(OwnPtr<T>& x) { return std::move(x); }

template <typename S, typename T>

class Base : public WebCallbacks<WebPassType<typename S::WebType>, WebPassType<typename T::WebType>> {

« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp » ('j') | no next file with comments »