mus: Show USER_PRIVATE window container during views tests

mus: Show USER_PRIVATE window container during views tests

If that container starts hidden then tests that open normal user windows will
not be able to focus/activate them.

* Ensure the --user-test-config flag is set in views tests
* Set the USER_PRIVATE container visible when --user-test-config is set
* Rename components/mus/common/args.h to switches.h and place in "switches"
  namespace for consistency with Chrome code
* Add logging to window server for focus failures
* Re-enable WidgetTestInteractive.TouchSelectionQuickMenuIsNotActivated

BUG=611601
TEST=views_mus_interactive_ui_tests as above

Committed: https://crrev.com/8118b48cd97c983be355bce77215faa6de9c61a0
Cr-Commit-Position: refs/heads/master@{#394310}

[James Cook, 2016-05-16 17:26:14]

jamescook@chromium.org changed reviewers:
+ sky@chromium.org

[James Cook, 2016-05-16 17:26:14]

sky, please take a look.

[sky, 2016-05-16 19:44:27]

https://codereview.chromium.org/1979323002/diff/1/components/mus/ws/window_tr...
File components/mus/ws/window_tree.cc (right):

https://codereview.chromium.org/1979323002/diff/1/components/mus/ws/window_tr...
components/mus/ws/window_tree.cc:298: LOG(WARNING) << "SetFocus failure, no
focused window to clear.";
I think these should be DVLOGs.

[James Cook, 2016-05-16 20:57:44]

sky, please take another look

https://codereview.chromium.org/1979323002/diff/1/components/mus/ws/window_tr...
File components/mus/ws/window_tree.cc (right):

https://codereview.chromium.org/1979323002/diff/1/components/mus/ws/window_tr...
components/mus/ws/window_tree.cc:298: LOG(WARNING) << "SetFocus failure, no
focused window to clear.";
On 2016/05/16 19:44:27, sky wrote:
> I think these should be DVLOGs.

How about DLOG? My concern with DVLOG is that no one I know runs with only
"--v=1" since Chrome prints about 100 lines per second of log with that flag.
But if we require "--vmodule" that mostly defeats the point of these logs. I'm
interested in letting the developer know that a problem they are experiencing in
their client app (focus isn't what they expect) is due to a behavior of the
window server. If I require vmodule I require the developer to already know
where to look.

[James Cook, 2016-05-16 21:43:01]

sky, please take another look.

https://codereview.chromium.org/1979323002/diff/1/components/mus/ws/window_tr...
File components/mus/ws/window_tree.cc (right):

https://codereview.chromium.org/1979323002/diff/1/components/mus/ws/window_tr...
components/mus/ws/window_tree.cc:298: LOG(WARNING) << "SetFocus failure, no
focused window to clear.";
On 2016/05/16 20:57:44, James Cook wrote:
> On 2016/05/16 19:44:27, sky wrote:
> > I think these should be DVLOGs.
> 
> How about DLOG? My concern with DVLOG is that no one I know runs with only
> "--v=1" since Chrome prints about 100 lines per second of log with that flag.
> But if we require "--vmodule" that mostly defeats the point of these logs. I'm
> interested in letting the developer know that a problem they are experiencing
in
> their client app (focus isn't what they expect) is due to a behavior of the
> window server. If I require vmodule I require the developer to already know
> where to look.

Discussed offline, switched to DVLOG.

[sky, 2016-05-16 23:51:48]

LGTM

[James Cook, 2016-05-17 19:10:51]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-05-17 19:10:52]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1979323002/#ps120001
(title: "rebase again, fix ViewsMusTestSuite")

[commit-bot: I haz the power, 2016-05-17 19:11:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1979323002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1979323002/120001

[commit-bot: I haz the power, 2016-05-17 21:14:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 21:14:23]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2016-05-17 23:36:14]

Description was changed from

==========
mus: Show USER_PRIVATE window container during views tests

If that container starts hidden then tests that open normal user windows will
not be able to focus/activate them.

* Ensure the --user-test-config flag is set in views tests
* Set the USER_PRIVATE container visible when --user-test-config is set
* Rename components/mus/common/args.h to switches.h and place in "switches"
  namespace for consistency with Chrome code
* Add logging to window server for focus failures
* Re-enable WidgetTestInteractive.WindowModalWindowDestroyedActivationTest
* Re-enable WidgetTestInteractive.TouchSelectionQuickMenuIsNotActivated

BUG=611601
TEST=views_mus_interactive_ui_tests as above
==========

to

==========
mus: Show USER_PRIVATE window container during views tests

If that container starts hidden then tests that open normal user windows will
not be able to focus/activate them.

* Ensure the --user-test-config flag is set in views tests
* Set the USER_PRIVATE container visible when --user-test-config is set
* Rename components/mus/common/args.h to switches.h and place in "switches"
  namespace for consistency with Chrome code
* Add logging to window server for focus failures
* Re-enable WidgetTestInteractive.TouchSelectionQuickMenuIsNotActivated

BUG=611601
TEST=views_mus_interactive_ui_tests as above
==========

[James Cook, 2016-05-17 23:40:36]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-05-17 23:40:36]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1979323002/#ps140001
(title: "rebase, fix linux")

[commit-bot: I haz the power, 2016-05-17 23:41:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1979323002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1979323002/140001

[commit-bot: I haz the power, 2016-05-17 23:49:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 23:49:52]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[James Cook, 2016-05-17 23:57:25]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-05-17 23:58:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1979323002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1979323002/140001

[commit-bot: I haz the power, 2016-05-18 01:43:32]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-05-18 01:45:30]

Description was changed from

==========
mus: Show USER_PRIVATE window container during views tests

If that container starts hidden then tests that open normal user windows will
not be able to focus/activate them.

* Ensure the --user-test-config flag is set in views tests
* Set the USER_PRIVATE container visible when --user-test-config is set
* Rename components/mus/common/args.h to switches.h and place in "switches"
  namespace for consistency with Chrome code
* Add logging to window server for focus failures
* Re-enable WidgetTestInteractive.TouchSelectionQuickMenuIsNotActivated

BUG=611601
TEST=views_mus_interactive_ui_tests as above
==========

to

==========
mus: Show USER_PRIVATE window container during views tests

If that container starts hidden then tests that open normal user windows will
not be able to focus/activate them.

* Ensure the --user-test-config flag is set in views tests
* Set the USER_PRIVATE container visible when --user-test-config is set
* Rename components/mus/common/args.h to switches.h and place in "switches"
  namespace for consistency with Chrome code
* Add logging to window server for focus failures
* Re-enable WidgetTestInteractive.TouchSelectionQuickMenuIsNotActivated

BUG=611601
TEST=views_mus_interactive_ui_tests as above

Committed: https://crrev.com/8118b48cd97c983be355bce77215faa6de9c61a0
Cr-Commit-Position: refs/heads/master@{#394310}
==========

[commit-bot: I haz the power, 2016-05-18 01:45:31]

Patchset 8 (id:??) landed as
https://crrev.com/8118b48cd97c983be355bce77215faa6de9c61a0
Cr-Commit-Position: refs/heads/master@{#394310}