mus: Show USER_PRIVATE window container during views tests

components/mus/ws/window_tree.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/mus/ws/window_tree.h"
 
 #include <stddef.h>
 
 #include <utility>
 
@@ skipping 276 matching lines @@
   if (window->opacity() == opacity)
     return true;
   Operation op(this, window_server_, OperationType::SET_WINDOW_OPACITY);
   window->SetOpacity(opacity);
   return true;
 }
 
 bool WindowTree::SetFocus(const ClientWindowId& window_id) {
   ServerWindow* window = GetWindowByClientId(window_id);
   ServerWindow* currently_focused = window_server_->GetFocusedWindow();
-  if (!currently_focused && !window)
+  if (!currently_focused && !window) {
+    LOG(WARNING) << "SetFocus failure, no focused window to clear.";

[sky, 2016/05/16 19:44:27]

I think these should be DVLOGs.

[James Cook, 2016/05/16 20:57:44]

How about DLOG? My concern with DVLOG is that no one I know runs with only
"--v=1" since Chrome prints about 100 lines per second of log with that flag.
But if we require "--vmodule" that mostly defeats the point of these logs. I'm
interested in letting the developer know that a problem they are experiencing in
their client app (focus isn't what they expect) is due to a behavior of the
window server. If I require vmodule I require the developer to already know
where to look.

[James Cook, 2016/05/16 21:43:01]

Discussed offline, switched to DVLOG.

     return false;
+  }
 
   Display* display = GetDisplay(window);
-  if (window && (!display || !window->can_focus() || !window->IsDrawn()))
+  if (window && (!display || !window->can_focus() || !window->IsDrawn())) {
+    LOG(WARNING) << "SetFocus failure, window cannot be focused.";
     return false;
+  }
 
-  if (!access_policy_->CanSetFocus(window))
+  if (!access_policy_->CanSetFocus(window)) {
+    LOG(WARNING) << "SetFocus failure, blocked by access policy.";
     return false;
+  }
 
   Operation op(this, window_server_, OperationType::SET_FOCUS);
-  return window_server_->SetFocusedWindow(window);
+  bool success = window_server_->SetFocusedWindow(window);
+  if (!success) {
+    LOG(WARNING) << "SetFocus failure, could not SetFocusedWindow.";
+  }
+  return success;
 }
 
 bool WindowTree::Embed(const ClientWindowId& window_id,
                        mojom::WindowTreeClientPtr client) {
   if (!client || !CanEmbed(window_id))
     return false;
   ServerWindow* window = GetWindowByClientId(window_id);
   PrepareForEmbed(window);
   // When embedding we don't know the user id of where the TreeClient came
   // from. Use an invalid id, which limits what the client is able to do.
@@ skipping 1136 matching lines @@
 }
 
 bool WindowTree::IsWindowRootOfAnotherTreeForAccessPolicy(
     const ServerWindow* window) const {
   WindowTree* tree = window_server_->GetTreeWithRoot(window);
   return tree && tree != this;
 }
 
 }  // namespace ws
 }  // namespace mus