Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1979263002: [Mac/GN] Do not EXPORT_SYMBOLS in //media/base/simd unless is_component_build. (Closed)

Created:
4 years, 7 months ago by Robert Sesek
Modified:
4 years, 7 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Do not EXPORT_SYMBOLS in //media/base/simd unless is_component_build. BUG=431177, 599950 R=sandersd@chromium.org Committed: https://crrev.com/8d852f7e89168e0a1d6f7da22ddc3b5317fe3ec6 Cr-Commit-Position: refs/heads/master@{#393926}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M media/base/BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Robert Sesek
4 years, 7 months ago (2016-05-16 15:45:03 UTC) #3
sandersd (OOO until July 31)
lgtm
4 years, 7 months ago (2016-05-16 21:09:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979263002/1
4 years, 7 months ago (2016-05-16 21:10:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-16 21:15:52 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 21:18:01 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8d852f7e89168e0a1d6f7da22ddc3b5317fe3ec6
Cr-Commit-Position: refs/heads/master@{#393926}

Powered by Google App Engine
This is Rietveld 408576698