Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: media/base/BUILD.gn

Issue 1979263002: [Mac/GN] Do not EXPORT_SYMBOLS in //media/base/simd unless is_component_build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/BUILD.gn
diff --git a/media/base/BUILD.gn b/media/base/BUILD.gn
index 4b1cd13ce440e6d89bc932352b4940ee6155ee1a..458d4ff6c96a67ea3675532c18b322b84fa8a9b9 100644
--- a/media/base/BUILD.gn
+++ b/media/base/BUILD.gn
@@ -537,10 +537,8 @@ if (current_cpu == "x86" || current_cpu == "x64") {
"simd/scale_yuv_to_rgb_sse.asm",
]
- # TODO(ajwong): Only export if shared_library build...
yasm_flags = [
"-DCHROMIUM",
- "-DEXPORT_SYMBOLS",
# In addition to the same path as source asm, let yasm %include
# search path be relative to src/ per Chromium policy.
@@ -548,6 +546,10 @@ if (current_cpu == "x86" || current_cpu == "x64") {
rebase_path("..", root_build_dir),
]
+ if (is_component_build) {
+ yasm_flags += [ "-DEXPORT_SYMBOLS" ]
+ }
+
inputs = [
"//third_party/x86inc/x86inc.asm",
"simd/convert_rgb_to_yuv_ssse3.inc",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698