Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1979243002: Readme update to make need for pdfium_is_standalone clear. (Closed)

Created:
4 years, 7 months ago by dsinclair
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez, _cary, caryclark
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Readme update to make need for pdfium_is_standalone clear. Add a note about the need for pdfium_is_standalone and fix some spelling mistakes along the way. Committed: https://pdfium.googlesource.com/pdfium/+/719a7a71d4cf1b714ad7f76e5f9ca28cfd5b74d3

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M README.md View 4 chunks +6 lines, -3 lines 2 comments Download

Messages

Total messages: 11 (5 generated)
dsinclair
PTAL.
4 years, 7 months ago (2016-05-16 14:42:30 UTC) #3
caryclark
lgtm
4 years, 7 months ago (2016-05-16 14:59:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979243002/20001
4 years, 7 months ago (2016-05-16 15:11:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001) as https://pdfium.googlesource.com/pdfium/+/719a7a71d4cf1b714ad7f76e5f9ca28cfd5b74d3
4 years, 7 months ago (2016-05-16 15:11:23 UTC) #9
Tom Sepez
https://codereview.chromium.org/1979243002/diff/20001/README.md File README.md (right): https://codereview.chromium.org/1979243002/diff/20001/README.md#newcode98 README.md:98: pdf_is_standalone = true # Set for a non-embedded build. ...
4 years, 7 months ago (2016-05-16 16:07:59 UTC) #10
dsinclair
4 years, 7 months ago (2016-05-16 18:40:29 UTC) #11
Message was sent while issue was closed.
https://codereview.chromium.org/1979243002/diff/20001/README.md
File README.md (right):

https://codereview.chromium.org/1979243002/diff/20001/README.md#newcode98
README.md:98: pdf_is_standalone = true  # Set for a non-embedded build.
On 2016/05/16 16:07:59, Tom Sepez wrote:
> should this say "Set false for a non-embedded build."


I don't think so, we want this true if we aren't embedded. It should be false
(the default) for an embedded build.

Powered by Google App Engine
This is Rietveld 408576698