Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: README.md

Issue 1979243002: Readme update to make need for pdfium_is_standalone clear. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: README.md
diff --git a/README.md b/README.md
index fb1498f64dc421d9da2a755c0297f33f3f4b2c0d..dbbed5be62dab2c8ad1a463327bb9260c62557f5 100644
--- a/README.md
+++ b/README.md
@@ -16,7 +16,7 @@ if you need to use the system toolchain. See
Get the chromium depot tools via the instructions at
http://www.chromium.org/developers/how-tos/install-depot-tools (this provides
-the gclient utilty needed below).
+the gclient utility needed below).
Also install Python, Subversion, and Git and make sure they're in your path.
@@ -76,7 +76,7 @@ gn gen <directory>
If you want to set <directory> to `out/Debug` or `out/Release` you'll need to
export `GYP_PDFIUM_NO_ACTION=1` to stop `gclient sync` from executing GYP
-and overwritting your build files.
+and overwriting your build files.
###<a name="BuildConfig"></a> Selecting build configuration
@@ -85,7 +85,7 @@ or without XFA forms support. Both of these features are enabled by
default. Also note that the XFA feature requires JavaScript.
Configuration is done by executing `gn args <directory>` to configure the build.
-This will lauch an editor in which you can set the following arguments.
+This will launch an editor in which you can set the following arguments.
```
use_goma = true # Googlers only.
@@ -100,6 +100,9 @@ pdf_is_standalone = true # Set for a non-embedded build.
clang_use_chrome_plugins = false # Currently must be false.
```
+Note, you must set `pdf_is_standalone = true` if you want the sample
+applications like `pdfium_test` to build.
+
When complete the arguments will be stored in `<directory>/args.gn`.
## Building the code
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698