Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1979033002: Kill log spam from PlatformKeyboardEvent::getCurrentModifierState. (Closed)

Created:
4 years, 7 months ago by skobes
Modified:
4 years, 7 months ago
Reviewers:
jbroman
CC:
blink-reviews, blink-reviews-events_chromium.org, chromium-reviews, dglazkov+blink, dtapuska+blinkwatch_chromium.org, dtapuska, eae+blinkwatch, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Kill log spam from PlatformKeyboardEvent::getCurrentModifierState. BUG=538289 Committed: https://crrev.com/6c4b7af309ae99a41b900c7408c717b9a1e0b88b Cr-Commit-Position: refs/heads/master@{#393950}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/PlatformKeyboardEvent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
skobes
4 years, 7 months ago (2016-05-14 00:47:40 UTC) #2
jbroman
lgtm
4 years, 7 months ago (2016-05-14 03:56:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979033002/1
4 years, 7 months ago (2016-05-16 15:44:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/222345)
4 years, 7 months ago (2016-05-16 18:28:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979033002/1
4 years, 7 months ago (2016-05-16 20:15:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-16 22:11:41 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 22:12:52 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6c4b7af309ae99a41b900c7408c717b9a1e0b88b
Cr-Commit-Position: refs/heads/master@{#393950}

Powered by Google App Engine
This is Rietveld 408576698