Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: third_party/WebKit/Source/platform/PlatformKeyboardEvent.cpp

Issue 1979033002: Kill log spam from PlatformKeyboardEvent::getCurrentModifierState. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/PlatformKeyboardEvent.cpp
diff --git a/third_party/WebKit/Source/platform/PlatformKeyboardEvent.cpp b/third_party/WebKit/Source/platform/PlatformKeyboardEvent.cpp
index 0d7cf82d21d0589350f84bec28e35a5aa29ad9a9..f5b0d9084250359e0a8279b93cde73df8fd5a205 100644
--- a/third_party/WebKit/Source/platform/PlatformKeyboardEvent.cpp
+++ b/third_party/WebKit/Source/platform/PlatformKeyboardEvent.cpp
@@ -113,8 +113,8 @@ PlatformEvent::Modifiers PlatformKeyboardEvent::getCurrentModifierState()
if (currentModifiers & ::cmdKey)
modifiers |= MetaKey;
#else
- // See https://crbug.com/538289
- NOTIMPLEMENTED();
+ // TODO(crbug.com/538289): Implement on other platforms.
+ return static_cast<Modifiers>(0);
#endif
return static_cast<Modifiers>(modifiers);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698