Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 19789006: Fix texture allocation in SWMaskHelper (Closed)

Created:
7 years, 5 months ago by robertphillips
Modified:
7 years, 5 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix texture allocation in SWMaskHelper

Patch Set 1 #

Patch Set 2 : Update for code review comments #

Total comments: 3

Patch Set 3 : Remove more code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -18 lines) Patch
M src/gpu/GrClipMaskManager.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrGpu.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrSWMaskHelper.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 1 2 2 chunks +2 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
robertphillips
7 years, 5 months ago (2013-07-19 17:20:12 UTC) #1
robertphillips
This patch removes the clear of the mask's texture since, due to its use, we ...
7 years, 5 months ago (2013-07-19 17:36:04 UTC) #2
bsalomon
https://codereview.chromium.org/19789006/diff/3001/src/gpu/GrSWMaskHelper.cpp File src/gpu/GrSWMaskHelper.cpp (left): https://codereview.chromium.org/19789006/diff/3001/src/gpu/GrSWMaskHelper.cpp#oldcode135 src/gpu/GrSWMaskHelper.cpp:135: I think we want to delete from here... https://codereview.chromium.org/19789006/diff/3001/src/gpu/GrSWMaskHelper.cpp#oldcode149 ...
7 years, 5 months ago (2013-07-19 17:42:28 UTC) #3
robertphillips
https://codereview.chromium.org/19789006/diff/3001/src/gpu/GrSWMaskHelper.cpp File src/gpu/GrSWMaskHelper.cpp (left): https://codereview.chromium.org/19789006/diff/3001/src/gpu/GrSWMaskHelper.cpp#oldcode149 src/gpu/GrSWMaskHelper.cpp:149: texture->writePixels(0, 0, fBM.width(), fBM.height(), You are correct - done.
7 years, 5 months ago (2013-07-19 17:54:47 UTC) #4
bsalomon
lgtm
7 years, 5 months ago (2013-07-19 18:07:49 UTC) #5
robertphillips
7 years, 5 months ago (2013-07-19 18:13:17 UTC) #6
Message was sent while issue was closed.
committed as r10197

Powered by Google App Engine
This is Rietveld 408576698