Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 197873029: Tweaked FlooringDiv back to TruncatingDiv again. (Closed)

Created:
6 years, 9 months ago by Sven Panne
Modified:
6 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Tweaked FlooringDiv back to TruncatingDiv again. This is a first step towards getting the flooring division by a constant working again (which will be a separate CL). R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20048

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -44 lines) Patch
M src/a64/lithium-codegen-a64.cc View 1 3 chunks +4 lines, -5 lines 0 comments Download
M src/a64/macro-assembler-a64.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/a64/macro-assembler-a64.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 3 chunks +4 lines, -5 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 3 chunks +4 lines, -9 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +4 lines, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 3 chunks +4 lines, -9 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
6 years, 9 months ago (2014-03-18 09:00:44 UTC) #1
Benedikt Meurer
LGTM
6 years, 9 months ago (2014-03-19 06:17:17 UTC) #2
Sven Panne
6 years, 9 months ago (2014-03-19 07:01:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r20048 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698