Issue 19787006: ports for mac, ios, android, linux, windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19787006: ports for mac, ios, android, linux, windows (Closed)

Created:
7 years, 5 months ago by Zach Reizner

Modified:
7 years, 5 months ago

Reviewers:
djsollen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

ports for mac, ios, android, linux, windows R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=10239

Patch Set 1 #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+153 lines, -42 lines)			Patch
M	experimental/skpdiff/SkCLImageDiffer.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	experimental/skpdiff/SkDiffContext.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	experimental/skpdiff/SkDifferentPixelsMetric_opencl.cpp	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	experimental/skpdiff/SkPMetric.cpp	View	5 chunks	+18 lines, -13 lines	0 comments	Download
M	experimental/skpdiff/SkPMetricUtil_generated.h	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	experimental/skpdiff/generate_pmetric_tables.py	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	experimental/skpdiff/main.cpp	View	5 chunks	+19 lines, -5 lines	0 comments	Download
M	experimental/skpdiff/skpdiff.gyp	View	1 chunk	+23 lines, -6 lines	0 comments	Download
M	experimental/skpdiff/skpdiff_util.h	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	experimental/skpdiff/skpdiff_util.cpp	View	4 chunks	+67 lines, -3 lines	0 comments	Download
M	experimental/skpdiff/viewer.html	View	1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Zach Reizner

https://codereview.chromium.org/19787006/diff/1/experimental/skpdiff/viewer.html File experimental/skpdiff/viewer.html (right): https://codereview.chromium.org/19787006/diff/1/experimental/skpdiff/viewer.html#newcode63 experimental/skpdiff/viewer.html:63: </html> I believe a newline got added here.

7 years, 5 months ago (2013-07-22 15:58:46 UTC) #1

Zach Reizner

7 years, 5 months ago (2013-07-22 17:05:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r10239 (presubmit successful).

Expand Messages | Collapse Messages