third_party/WebKit/Source/platform/text/Hyphenation.h - Issue 1978683002: Enable hyphens: auto and none in BreakingContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/text/Hyphenation.h

Issue 1978683002: Enable hyphens: auto and none in BreakingContext (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comments for heuristic, adjust widths of hyphens-auto-mock test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/text/Hyphenation.h

diff --git a/third_party/WebKit/Source/platform/text/Hyphenation.h b/third_party/WebKit/Source/platform/text/Hyphenation.h

index 95d1e4c980249242ce58f58cd9e0dc11ed03bd8a..bd86f5ae610c76c9eb71bf612134fbf6ba837d50 100644

--- a/third_party/WebKit/Source/platform/text/Hyphenation.h

+++ b/third_party/WebKit/Source/platform/text/Hyphenation.h

@@ -14,15 +14,13 @@

namespace blink {

-class StringView;

class PLATFORM_EXPORT Hyphenation : public RefCounted<Hyphenation> {

public:

virtual ~Hyphenation() {}

static Hyphenation* get(const AtomicString& locale);

- virtual size_t lastHyphenLocation(const StringView&, size_t beforeIndex, const AtomicString& locale) const = 0;

+ virtual size_t lastHyphenLocation(const StringView&, size_t beforeIndex) const = 0;

static void setForTesting(const AtomicString& locale, PassRefPtr<Hyphenation>);

static void clearForTesting();