third_party/WebKit/Source/platform/text/Hyphenation.cpp - Issue 1978683002: Enable hyphens: auto and none in BreakingContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/text/Hyphenation.cpp

Issue 1978683002: Enable hyphens: auto and none in BreakingContext (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comments for heuristic, adjust widths of hyphens-auto-mock test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/text/Hyphenation.cpp

diff --git a/third_party/WebKit/Source/platform/text/Hyphenation.cpp b/third_party/WebKit/Source/platform/text/Hyphenation.cpp

index 357ffb78a9cb5c0184b227771e1e73bd9e7088f2..563b60f101c31bf096436336029030a7dfc7ab43 100644

--- a/third_party/WebKit/Source/platform/text/Hyphenation.cpp

+++ b/third_party/WebKit/Source/platform/text/Hyphenation.cpp

@@ -16,6 +16,7 @@ Hyphenation::HyphenationMap& Hyphenation::getHyphenationMap()

Hyphenation* Hyphenation::get(const AtomicString& locale)

{

+ DCHECK(!locale.isNull());

Hyphenation::HyphenationMap& hyphenationMap = getHyphenationMap();

auto result = hyphenationMap.add(locale, nullptr);

if (result.isNewEntry)