Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1978643002: Now able to set Chrome as the default browser on Mac. (Closed)

Created:
4 years, 7 months ago by Patrick Monette
Modified:
4 years, 7 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Now able to set Chrome as the default browser on Mac. Fixed a bug introduced by the refactoring done in crrev.com/386487 BUG=610203 Committed: https://crrev.com/ee80b2e21a1d7b3dea8d85584a40123f64ed76f7 Cr-Commit-Position: refs/heads/master@{#393384}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/shell_integration_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Patrick Monette
PTAL
4 years, 7 months ago (2016-05-12 20:54:08 UTC) #3
Robert Sesek
lgtm
4 years, 7 months ago (2016-05-12 22:16:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978643002/20001
4 years, 7 months ago (2016-05-12 22:18:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-12 22:55:31 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 22:56:59 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee80b2e21a1d7b3dea8d85584a40123f64ed76f7
Cr-Commit-Position: refs/heads/master@{#393384}

Powered by Google App Engine
This is Rietveld 408576698