chrome/browser/shell_integration_mac.mm - Issue 1978643002: Now able to set Chrome as the default browser on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/shell_integration_mac.mm

Issue 1978643002: Now able to set Chrome as the default browser on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/shell_integration_mac.mm

diff --git a/chrome/browser/shell_integration_mac.mm b/chrome/browser/shell_integration_mac.mm

index 4fcf4b98b307a61a1c2f47b09b710a2dace8aa59..eab3d21dc53788feef71b7aec188c283054421cb 100644

--- a/chrome/browser/shell_integration_mac.mm

+++ b/chrome/browser/shell_integration_mac.mm

@@ -53,7 +53,7 @@ bool IsIdentifierDefaultProtocolClient(NSString* identifier,

// applies only for the current user. Returns false if this cannot be done, or

// if the operation fails.

bool SetAsDefaultBrowser() {

- if (CanSetAsDefaultBrowser())

+ if (!CanSetAsDefaultBrowser())

return false;

// We really do want the outer bundle here, not the main bundle since setting

« no previous file with comments | « no previous file | no next file » | no next file with comments »