Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1978553002: Refactor extracting search terms from Template URL. (Closed)

Created:
4 years, 7 months ago by Vitaly Baranov
Modified:
4 years, 6 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@support-prefix-path-matching-when-extracting-terms-from-template-url
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor extracting search terms from Template URL. TEST=components_unittests.TemplateURLTest.HostAndSearchTermKey R=pkasting@chromium.org

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -93 lines) Patch
M components/search_engines/template_url.h View 3 chunks +18 lines, -7 lines 0 comments Download
M components/search_engines/template_url.cc View 9 chunks +67 lines, -34 lines 4 comments Download
M components/search_engines/template_url_unittest.cc View 1 chunk +54 lines, -52 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 4 (0 generated)
Vitaly Baranov
4 years, 7 months ago (2016-05-12 15:13:59 UTC) #1
Vitaly Baranov
https://codereview.chromium.org/1978553002/diff/1/components/search_engines/template_url.cc File components/search_engines/template_url.cc (right): https://codereview.chromium.org/1978553002/diff/1/components/search_engines/template_url.cc#newcode153 components/search_engines/template_url.cc:153: SearchTermsInPathResult FindSearchTermsInPath(const base::StringPiece& path) { Changed for consistency with ...
4 years, 7 months ago (2016-05-12 15:24:12 UTC) #2
Peter Kasting
This doesn't have an associated bug, or a description of what the refactoring in question ...
4 years, 7 months ago (2016-05-17 04:13:25 UTC) #3
Vitaly Baranov
4 years, 6 months ago (2016-05-30 12:52:38 UTC) #4
I can split this CL into separate pieces.
The first one is https://codereview.chromium.org/2021773003

Powered by Google App Engine
This is Rietveld 408576698