Refactor extracting search terms from Template URL.

Refactor extracting search terms from Template URL.

TEST=components_unittests.TemplateURLTest.HostAndSearchTermKey

R=pkasting@chromium.org

[Vitaly Baranov, 2016-05-12 15:24:12]

https://codereview.chromium.org/1978553002/diff/1/components/search_engines/t...
File components/search_engines/template_url.cc (right):

https://codereview.chromium.org/1978553002/diff/1/components/search_engines/t...
components/search_engines/template_url.cc:153: SearchTermsInPathResult
FindSearchTermsInPath(const base::StringPiece& path) {
Changed for consistency with
https://codereview.chromium.org/1902263002/diff/20001/components/search_engin...

https://codereview.chromium.org/1978553002/diff/1/components/search_engines/t...
components/search_engines/template_url.cc:453: }
With these two function we can check the prefix and suffix in unit-tests.

https://codereview.chromium.org/1978553002/diff/1/components/search_engines/t...
components/search_engines/template_url.cc:518: (url.path() != path_))) {
Optimization.

https://codereview.chromium.org/1978553002/diff/1/components/search_engines/t...
components/search_engines/template_url.cc:604:
search_term_value_suffix_.clear();
Minor fix.

[Peter Kasting, 2016-05-17 04:13:25]

This doesn't have an associated bug, or a description of what the refactoring in
question is accomplishing.  The only place those things are described is in a
codereview comment on https://codereview.chromium.org/1968303002/ , which
implies this is doing several different possibly-independent things.

It may or may not make sense to split this into separate functional pieces.  Do
so if it makes sense, otherwise at least update this CL with the above
information.  Give details on how the functional changes work, especially what
functional effect the changes have where you're rewriting things for consistency
with https://codereview.chromium.org/1902263002/ .  Hopefully this will all make
it clear whether the new tests you're adding are just expanding pre-existing
testing, testing some of your new functional changes, or both.

[Vitaly Baranov, 2016-05-30 12:52:38]

I can split this CL into separate pieces.
The first one is https://codereview.chromium.org/2021773003