Refactor extracting search terms from Template URL.

components/search_engines/template_url_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/base_paths.h"
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 699 matching lines @@
   GURL result(url.url_ref().ReplaceSearchTerms(args, search_terms_data_));
   ASSERT_TRUE(result.is_valid());
   EXPECT_EQ("http://bar/?rlz=" + base::UTF16ToUTF8(rlz_string) + "&x",
             result.spec());
 }
 
 TEST_F(TemplateURLTest, HostAndSearchTermKey) {
   struct TestData {
     const std::string url;
     const std::string host;
+    const url::Parsed::ComponentType location;
     const std::string path;
     const std::string search_term_key;
+    const std::string search_term_value_prefix;
+    const std::string search_term_value_suffix;
   } test_data[] = {
-    { "http://blah/?foo=bar&q={searchTerms}&b=x", "blah", "/", "q"},
-    { "http://blah/{searchTerms}", "blah", "/", ""},
+    { "http://blah/?foo=bar&q={searchTerms}&b=x",
+      "blah", url::Parsed::QUERY, "/", "q", "", ""},
+
+    { "http://blah/?foo=bar#q={searchTerms}&b=x",
+      "blah", url::Parsed::REF, "/", "q", "", ""},
+
+    { "http://blah/{searchTerms}",
+      "blah", url::Parsed::PATH, "/", "", "/", ""},
+
+    { "http://blah/{searchTerms}/",
+      "blah", url::Parsed::PATH, "//", "", "/", "/"},
+
+    { "http://blah/begin/{searchTerms}/end",
+      "blah", url::Parsed::PATH, "/begin//end", "", "/begin/", "/end"},
 
     // No term should result in empty values.
-    { "http://blah/", "", "", ""},
+    { "http://blah/", "", url::Parsed::QUERY, "", "", "", ""},
+
+    // Term in the host shouldn't match.
+    { "http://{searchTerms}", "", url::Parsed::QUERY, "", "", "", "" },
+
+    // searchTerms is a key, not a value, so this should result in an empty
+    // value.
+    { "http://blah/?foo=bar#x=012345678901234&a=b&{searchTerms}=x",
+      "", url::Parsed::QUERY, "", "", "", "" },
 
     // Multiple terms should result in empty values.
-    { "http://blah/?q={searchTerms}&x={searchTerms}", "", "", ""},
+    { "http://blah/?q={searchTerms}&x={searchTerms}",
+      "", url::Parsed::QUERY, "", "", "", "" },
 
-    // Term in the host shouldn't match.
-    { "http://{searchTerms}", "", "", ""},
+    { "http://blah/{searchTerms}?q={searchTerms}",
+      "", url::Parsed::QUERY, "", "", "", "" },
 
-    { "http://blah/?q={searchTerms}", "blah", "/", "q"},
-    { "https://blah/?q={searchTerms}", "blah", "/", "q"},
+    { "http://blah/{searchTerms}#x={searchTerms}",
+      "", url::Parsed::QUERY, "", "", "", "" },
 
-    // Single term with extra chars in value should match.
-    { "http://blah/?q=stock:{searchTerms}", "blah", "/", "q"},
+    // Fixed prefixes and suffixes in query or ref.
+    { "http://blah/?q=stock:{searchTerms}",
+      "blah", url::Parsed::QUERY, "/", "q", "stock:", ""},
+
+    { "http://www.example.com/?q=chromium-{searchTerms}@chromium.org",
+      "www.example.com", url::Parsed::QUERY, "/", "q", "chromium-",
+      "@chromium.org" },
+
+    { "http://www.example.com/#q=chromium-{searchTerms}@chromium.org",
+      "www.example.com", url::Parsed::REF, "/", "q", "chromium-",
+      "@chromium.org" },
+
+    { "http://www.example.com/chromium-{searchTerms}@chromium.org/info",
+      "www.example.com", url::Parsed::PATH, "/chromium-@chromium.org/info",
+      "", "/chromium-", "@chromium.org/info" },
   };
 
   for (size_t i = 0; i < arraysize(test_data); ++i) {
     TemplateURLData data;
     data.SetURL(test_data[i].url);
     TemplateURL url(data);
-    EXPECT_EQ(test_data[i].host, url.url_ref().GetHost(search_terms_data_));
-    EXPECT_EQ(test_data[i].path, url.url_ref().GetPath(search_terms_data_));
+    const TemplateURLRef& url_ref = url.url_ref();
+    EXPECT_EQ(test_data[i].host, url_ref.GetHost(search_terms_data_));
+    EXPECT_EQ(test_data[i].location,
+              url_ref.GetSearchTermKeyLocation(search_terms_data_));
+    EXPECT_EQ(test_data[i].path, url_ref.GetPath(search_terms_data_));
     EXPECT_EQ(test_data[i].search_term_key,
-              url.url_ref().GetSearchTermKey(search_terms_data_));
+              url_ref.GetSearchTermKey(search_terms_data_));
+    EXPECT_EQ(test_data[i].search_term_value_prefix,
+              url_ref.GetSearchTermValuePrefix(search_terms_data_));
+    EXPECT_EQ(test_data[i].search_term_value_suffix,
+              url_ref.GetSearchTermValueSuffix(search_terms_data_));
   }
 }
 
-TEST_F(TemplateURLTest, SearchTermKeyLocation) {
-  struct TestData {
-    const std::string url;
-    const url::Parsed::ComponentType location;
-    const std::string path;
-    size_t position_in_path;
-  } test_data[] = {
-    { "http://blah/{searchTerms}/", url::Parsed::PATH, "//", 1 },
-    { "http://blah/{searchTerms}", url::Parsed::PATH, "/", 1 },
-    { "http://blah/begin/{searchTerms}/end", url::Parsed::PATH, "/begin//end", 7 },
-
-    { "http://blah/?foo=bar&q={searchTerms}&b=x", url::Parsed::QUERY,
-      "/", std::string::npos },
-    { "http://blah/?foo=bar#x={searchTerms}&b=x", url::Parsed::REF,
-      "/", std::string::npos },
-    // searchTerms is a key, not a value, so this should result in an empty
-    // value.
-    { "http://blah/?foo=bar#x=012345678901234&a=b&{searchTerms}=x",
-      url::Parsed::QUERY, std::string(), std::string::npos },
-
-    // Multiple search terms should result in empty values.
-    { "http://blah/{searchTerms}?q={searchTerms}", url::Parsed::QUERY,
-      "", std::string::npos },
-    { "http://blah/{searchTerms}#x={searchTerms}", url::Parsed::QUERY,
-      "", std::string::npos },
-    { "http://blah/?q={searchTerms}#x={searchTerms}", url::Parsed::QUERY,
-      "", std::string::npos },
-  };
-
-  for (size_t i = 0; i < arraysize(test_data); ++i) {
-    TemplateURLData data;
-    data.SetURL(test_data[i].url);
-    TemplateURL url(data);
-    EXPECT_EQ(test_data[i].location,
-              url.url_ref().GetSearchTermKeyLocation(search_terms_data_));
-    EXPECT_EQ(test_data[i].path,
-              url.url_ref().GetPath(search_terms_data_));
-    EXPECT_EQ(test_data[i].position_in_path,
-              url.url_ref().GetSearchTermPositionInPath(search_terms_data_));
-  }
-}
-
 TEST_F(TemplateURLTest, GoogleBaseSuggestURL) {
   static const struct {
     const char* const base_url;
     const char* const base_suggest_url;
   } data[] = {
     { "http://google.com/", "http://google.com/complete/", },
     { "http://www.google.com/", "http://www.google.com/complete/", },
     { "http://www.google.co.uk/", "http://www.google.co.uk/complete/", },
     { "http://www.google.com.by/", "http://www.google.com.by/complete/", },
     { "http://google.com/intl/xx/", "http://google.com/complete/", },
@@ skipping 999 matching lines @@
       GURL("https://www.foo.org/search?q=Y+Z"),
       search_terms_data_, &search_terms));
   EXPECT_EQ(base::ASCIIToUTF16("Y Z"), search_terms);
   EXPECT_TRUE(url.ExtractSearchTermsFromURL(
       GURL("https://www.foo.org/s#q=123"),
       search_terms_data_, &search_terms));
   EXPECT_EQ(base::ASCIIToUTF16("123"), search_terms);
 
   search_terms_data_.set_google_base_url("http://www.google.com/");
 }