Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: runtime/bin/vmservice/client/lib/src/service/object.dart

Issue 197853005: Show object pool on code page (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/service/object.dart
diff --git a/runtime/bin/vmservice/client/lib/src/service/object.dart b/runtime/bin/vmservice/client/lib/src/service/object.dart
index bbfe10a4c619b052a9e9e41a7a6c286dee7f29d0..d50113a1ffd925fd8b26f735ea5e3bd3da752533 100644
--- a/runtime/bin/vmservice/client/lib/src/service/object.dart
+++ b/runtime/bin/vmservice/client/lib/src/service/object.dart
@@ -475,7 +475,7 @@ class Code extends ServiceObject {
@reflectable final addressTicks = new ObservableMap<int, CodeTick>();
@observable String formattedInclusiveTicks = '';
@observable String formattedExclusiveTicks = '';
-
+ @observable ServiceMap objectPool;
@observable ServiceMap function;
String name;
String vmName;
@@ -547,7 +547,7 @@ class Code extends ServiceObject {
'($inclusiveTicks)';
formattedExclusiveTicks =
'${formatPercent(exclusiveTicks, totalSamplesInProfile)} '
- '($inclusiveTicks)';
+ '($exclusiveTicks)';
Cutch 2014/03/14 14:37:21 One line fix for unrelated bug.
}
void _update(ObservableMap m) {
@@ -559,8 +559,8 @@ class Code extends ServiceObject {
kind = CodeKind.fromString(m['kind']);
startAddress = int.parse(m['start'], radix:16);
endAddress = int.parse(m['end'], radix:16);
- // Upgrade the function.
- function = _upgradeToServiceObject(isolate.vm, isolate, m['function']);
+ function = _upgradeToServiceObject(vm, isolate, m['function']);
+ objectPool = _upgradeToServiceObject(vm, isolate, m['object_pool']);
var disassembly = m['disassembly'];
if (disassembly != null) {
_processDisassembly(disassembly);

Powered by Google App Engine
This is Rietveld 408576698