runtime/bin/vmservice/client/lib/src/service/service.dart - Issue 197853005: Show object pool on code page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/service/service.dart

Issue 197853005: Show object pool on code page (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/vmservice/client/lib/src/service/service.dart

diff --git a/runtime/bin/vmservice/client/lib/src/service/service.dart b/runtime/bin/vmservice/client/lib/src/service/service.dart

index 36711169f6249ff45867f771199db528ff6c7cd2..ff8fe037f8300f1d25d069887961004e43ac075d 100644

--- a/runtime/bin/vmservice/client/lib/src/service/service.dart

+++ b/runtime/bin/vmservice/client/lib/src/service/service.dart

@@ -164,6 +164,9 @@ void _upgradeObservableList(ObservableList list, VM vm, Isolate isolate) {

/// This acts like a factory which consumes an ObservableMap and returns

/// a fully upgraded ServiceObject.

ServiceObject _upgradeToServiceObject(VM vm, Isolate isolate, ObservableMap m) {

+ if (m == null) {

+ return null;

+ }

if (!ServiceObject.isServiceMap(m)) {

Logger.root.severe("Malformed service object: $m");

}