Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1455)

Issue 1978483004: Disk cache perf test: guard linux only flushes, add fd limit control. (Closed)

Created:
4 years, 7 months ago by gavinp
Modified:
4 years, 7 months ago
Reviewers:
Julia Tuttle
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@open-speeder-3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disk cache perf test: guard linux only flushes, add fd limit control. The system cache flush utilities can't flush directories except on Linux, so don't try. As well, it's only a convenience (since you can set the ulimit yourself in shell before running the test), but it's nice if the test just automatically gives itself an appropriate open file descriptor test limit. R=juliatuttle@chromium.org BUG=611464 TEST=None Committed: https://crrev.com/c77d596b47fc4ece347e94c53db0d4daa16d75fd Cr-Commit-Position: refs/heads/master@{#393773}

Patch Set 1 #

Patch Set 2 : suck less on windows #

Patch Set 3 : more windows guards #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
M net/disk_cache/disk_cache_perftest.cc View 1 2 5 chunks +36 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
Julia Tuttle
lgtm.
4 years, 7 months ago (2016-05-13 16:28:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978483004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978483004/1
4 years, 7 months ago (2016-05-13 19:07:20 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/221445)
4 years, 7 months ago (2016-05-13 20:33:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978483004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978483004/40001
4 years, 7 months ago (2016-05-15 16:31:09 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-15 17:18:58 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-15 17:20:23 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c77d596b47fc4ece347e94c53db0d4daa16d75fd
Cr-Commit-Position: refs/heads/master@{#393773}

Powered by Google App Engine
This is Rietveld 408576698